Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial SDK #14

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add serial SDK #14

wants to merge 1 commit into from

Conversation

balloob
Copy link
Contributor

@balloob balloob commented Nov 15, 2021

This adds the serial SDK to the improv homepage.

Marked as draft because it requires an update to the SDKs. Although the SDKs now register the used MWC components under their own prefix, <mwc-textfield> imports <mwc-notched-outline> which currently causes an error because it will end up being defined twice.

https://github.com/material-components/material-web/blob/987a534fe75555a1a6b0854f0f9b9f999d72b7d0/packages/textfield/mwc-textfield-base.ts#L326

TODO

  • SDKs to work with notched outline
  • Update "Serial SDK for JavaScript" example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant