Port carrying from DV [DO NOT MERGE] #1790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Youre doing some cocomelon shit to me |
|
It's hard to make a comparison, but this one is using better implementation of movement speed modifier, and is also using Entity<T>. It seems better written so it gets my vote. |
mqole
added
the
PR limbo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebuild of #1693, using code from DELTA-V. This is one of two different versions of this PR, the other using code from Frontier Station. Please see #1789 for the other version of this PR.
Both iterations of the carrying system are different. I recommend checking each version out in a localhost to test the differences yourself: if you are new to this, just paste the following code into git bash.
git checkout -b mqole-carrying-dv mastergit pull https://github.com/mqole/imp-station-14.git carrying-dvports DeltaV-Station/Delta-v#2466.
ripped out everything related to pseudoitems because thats something they got for goblins and vulps. testing it seems to work ok, but would really love people more experienced in c# to come look because i'm not that good at this.
🆑
add: You can now pick your friends up like a ragdoll.
add: You can now throw your friends really, really far.