thaven refactoring

[deltanedas]

cleaned up everything because why not

also related the no contractions accent doesnt do anything (its an identity "accent" just sets output to the input) did @widgetbeck mean to commit it here?

Media

still works

Technical details

• renamed ThavenMoodBoundComponent.cs to ThavenMoodsComponent.cs because thats the class name
• made ThavenMoodPrototype inherit ThavenMood similar to silicon laws
• properly networked moods so client doesnt need the (non-shared) mood list to be in bui state
  it should also just work in 8 years when persistence real
• general refactor of everything
• moved wildcard adding into its own function that deltav glimmer event uses, made emag use it too
• add docs to a bunch of random undocumented fields and methods

Breaking changes

every method using EntityUid uid, ThavenMoodsComponent? comp now takes Entity<ThavenMoodsComponent>
BUI state no longer has Moods, its networked on the component

Changelog
no cl

[honeyed-lemons]

damn

[kipdotnet]

real

[Sha-Seng]

i KNOW i've seen no contractions work, because i remember somebody having it once and it turns "ma'am" into "madame" which they didn't like so they turned it off again.......... but either it broke or it just doesn't work on thaven, if they're all supposed to sound like that

[deltanedas]

afaik its never done anything, from its conception it hasnt done anything in code

[widgetbeck]

No contractions works. I've tested it. If it doesn't work, it wasn't because of a change I made.

…

On Sun, Mar 2, 2025, 05:48 deltanedas ***@***.***> wrote: afaik its never done anything, from its conception it hasnt done anything in code — Reply to this email directly, view it on GitHub <#1810 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BG6OZJDGYFST72U2Q2IRGLD2SLOWXAVCNFSM6AAAAABYEQQKU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJSGY3TCNBZGY> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: deltanedas]*deltanedas* left a comment (impstation/imp-station-14#1810) <#1810 (comment)> afaik its never done anything, from its conception it hasnt done anything in code — Reply to this email directly, view it on GitHub <#1810 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BG6OZJDGYFST72U2Q2IRGLD2SLOWXAVCNFSM6AAAAABYEQQKU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJSGY3TCNBZGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[widgetbeck]

I'll take a look at the rest of this tomorrow probably

…

On Sun, Mar 2, 2025, 06:02 Beck ***@***.***> wrote: No contractions works. I've tested it. If it doesn't work, it wasn't because of a change I made. On Sun, Mar 2, 2025, 05:48 deltanedas ***@***.***> wrote: > afaik its never done anything, from its conception it hasnt done anything > in code > > — > Reply to this email directly, view it on GitHub > <#1810 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BG6OZJDGYFST72U2Q2IRGLD2SLOWXAVCNFSM6AAAAABYEQQKU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJSGY3TCNBZGY> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > [image: deltanedas]*deltanedas* left a comment > (impstation/imp-station-14#1810) > <#1810 (comment)> > > afaik its never done anything, from its conception it hasnt done anything > in code > > — > Reply to this email directly, view it on GitHub > <#1810 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BG6OZJDGYFST72U2Q2IRGLD2SLOWXAVCNFSM6AAAAABYEQQKU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJSGY3TCNBZGY> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[deltanedas]

the system defines regexes and doesnt use them, i think its actually implemented with a generic system?