Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not what they're called #1851

Merged
merged 2 commits into from
Mar 7, 2025
Merged

not what they're called #1851

merged 2 commits into from
Mar 7, 2025

Conversation

nowaitstop
Copy link

Amoung_pequeno

Changelog

  • tweak: not what they're called

@kipdotnet
Copy link

Changing the id of the item is gonna remove it everywhere its mapped and throw errors instead btw

@nowaitstop
Copy link
Author

darn I thought that might be how it is... time to find where it's mapped

@honeyed-lemons
Copy link

oh yeahhhh change just the name

@hivehum
Copy link

hivehum commented Mar 6, 2025

oh yeah you need to add a migration.yml entry and change every storage fill that has the amoung pequeno etc etc

@DinnerCalzone
Copy link

I would recommend against changing the ID of the prototype. Doing so would require adding it to migrations.yml or else it will throw errors and cause maps that have them to not load, and it's such a small discrepancy between the id and the name that it's really not worth it.

@Sha-Seng
Copy link

Sha-Seng commented Mar 6, 2025

you CAN in fact just change the item's name and not it's ID, nobody but devs will ever know the difference

@nowaitstop
Copy link
Author

yeah..... SIGH.... I'll do the easier thing....... it's just.. not what they're called, is all......

Copy link

@kipdotnet kipdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@kipdotnet kipdotnet merged commit 00f6c8e into impstation:master Mar 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants