Merge pull request #154 from inaka/harenson.153.elvis-approves-the-ch…

…anges-but-the-check-fails [Fix #153] Make check pass when PR is approved
inaka · Jul 17, 2017 · 8969dae · 8969dae
2 parents ed9f471 + 4cb4c67
commit 8969dae
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/egithub_webhook.erl b/src/egithub_webhook.erl
@@ -186,6 +186,9 @@ do_handle_pull_request(Module, Cred, #{<<"number">> := PR,
   {ok, GithubFiles} = egithub:pull_req_files(Cred, Repo, PR),
   case Module:handle_pull_request(Cred, Data, GithubFiles) of
     {ok, []} -> clean;
+    {ok, #{event := <<"APPROVE">>, comments := []} = Messages} ->
+      ok = handle_messages_or_review(Cred, Repo, PR, Messages),
+      clean;
     {ok, Messages} ->
       ok = handle_messages_or_review(Cred, Repo, PR, Messages),
       with_warnings;