Trigger checks after each commit PR ready for review #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #227 didn't work as wished: commits of an open PR ready for review didn't trigger the automatic checks. Only the switch from draft to PR triggered such checks, which is not enough.
Solution here implemented comes from this GitHub discussion comment: https://github.com/orgs/community/discussions/25722#discussioncomment-3248917
It seems also that the workflow dispatch trigger works, i.e. the
if: github.event.pull_request.draft == falsein the jobs doesn't skip the action when it is manually triggered. I have just checked by triggering the R-CMD-check action on this PR with status draft, see https://github.com/inbo/camtraptor/actions/runs/5543168228/workflow