-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
268 add news.md #269
268 add news.md #269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It seems that the current bullet points are already implemented and should be listed under a
camtraptor 0.20.0
header? - The newly planned things for 1.0 should (for now) be listed under
camtraptor (development version)
Well spotted Peter. Changes in #207 are already implemented, but changes in #244 were merged into the
I was planning to merge this into v1.0, but if merging into main instead, I agree things merged into v1.0 should indeed go under camtraptor (development version)
|
Decided with @PietrH to not mention v0.20 or earlier versions in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔝
leaflet.providers is dependent on R3.6, so we need to up our minimum R requirement to R3.6 |
(3.6.0 instead of 3.6.3)
set Ubuntu to R3.6.3 to see if it fixes failing R CMD CHECK
Nice move ♟️ I think we are ready to merge this and move on? Once on v1.0, please pull the updated v1.0 in branch 259-datapkg-argument . In any case, I start the review of #271. |
32137d3
to
1a26fe5
Compare
Fixes #268
Using the
NEWS.md
from frictionless as inspiration, I've added a NEWS.md with items from #244 and #207. I usedusethis::use_news_md()
.I suggest we update
NEWS.md
iteratively as we bring more changes to the v1.0 branch.