Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

268 add news.md #269

Merged
merged 9 commits into from
Sep 5, 2023
Merged

268 add news.md #269

merged 9 commits into from
Sep 5, 2023

Conversation

PietrH
Copy link
Member

@PietrH PietrH commented Sep 4, 2023

Fixes #268

Using the NEWS.md from frictionless as inspiration, I've added a NEWS.md with items from #244 and #207. I used usethis::use_news_md().

I suggest we update NEWS.md iteratively as we bring more changes to the v1.0 branch.

@PietrH PietrH added documentation Improvements or additions to documentation v1.0 labels Sep 4, 2023
@PietrH PietrH added this to the v1.0 milestone Sep 4, 2023
@PietrH PietrH self-assigned this Sep 4, 2023
@PietrH PietrH linked an issue Sep 4, 2023 that may be closed by this pull request
Copy link
Member

@peterdesmet peterdesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It seems that the current bullet points are already implemented and should be listed under a camtraptor 0.20.0 header?
  • The newly planned things for 1.0 should (for now) be listed under camtraptor (development version)

@PietrH PietrH marked this pull request as draft September 4, 2023 08:18
@PietrH
Copy link
Member Author

PietrH commented Sep 4, 2023

Well spotted Peter. Changes in #207 are already implemented, but changes in #244 were merged into the v1.0 branch, not main.

  • Do you think planned changes should be added to a separate heading camtraptor (development version), even if they are not implemented in any branch at all?

I was planning to merge this into v1.0, but if merging into main instead, I agree things merged into v1.0 should indeed go under camtraptor (development version)

  • Should we add this NEWS.md as part of v1.0 or earlier?

@damianooldoni
Copy link
Member

damianooldoni commented Sep 4, 2023

Hi. Well, not really. The only bullet point linked to something already developed, i.e. in main (v0.20), is

write_dwc() is now faster (#192)".

This issue seems solved by #207

@damianooldoni damianooldoni mentioned this pull request Sep 4, 2023
@damianooldoni damianooldoni changed the title 268 add newsmd 268 add news.md Sep 4, 2023
@PietrH PietrH marked this pull request as ready for review September 4, 2023 08:42
@damianooldoni
Copy link
Member

Decided with @PietrH to not mention v0.20 or earlier versions in NEWS.md.

Copy link
Member

@damianooldoni damianooldoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@damianooldoni damianooldoni removed the v1.0 label Sep 4, 2023
@PietrH
Copy link
Member Author

PietrH commented Sep 4, 2023

leaflet.providers is dependent on R3.6, so we need to up our minimum R requirement to R3.6

@damianooldoni damianooldoni mentioned this pull request Sep 4, 2023
set Ubuntu to R3.6.3 to see if it fixes failing R CMD CHECK
@damianooldoni
Copy link
Member

Nice move ♟️
In this way we have a minimal check at 3.6.0 using Windows, probably the OS of the vast majority of users.

I think we are ready to merge this and move on? Once on v1.0, please pull the updated v1.0 in branch 259-datapkg-argument . In any case, I start the review of #271.

@PietrH PietrH merged commit 2778629 into v1.0 Sep 5, 2023
8 checks passed
@PietrH PietrH deleted the 268-add-newsmd branch September 5, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add news.md
3 participants