New mechanism to hide some radars from the selection map #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @niconoe! To avoid negations, can I suggest |
|
Done, I negated the negation for a more positive outcome :D |
peterdesmet
approved these changes
Oct 24, 2024
| @@ -54,6 +54,7 @@ export interface RadarInterface { | |||
| endpoint: string; // URL template, some variables are interpolated. Example: 'https://opendata.meteo.be/ftp/observations/radar/vbird/{odimCode}/{yyyy}/{odimCode}_vpts_{yyyymmdd}.txt' | |||
| vptsFileFormat: VPTSFileFormat; | |||
| heights: number[]; // Data is available at the following heights | |||
| showOnMap?: boolean; // If false, the radar will not be displayed on the map | |||
There was a problem hiding this comment.
Suggested change
| showOnMap?: boolean; // If false, the radar will not be displayed on the map | |
| showOnMap?: boolean; // If false, the radar will not be displayed on the map (default true) |
Note is the ? intentional?
| @@ -27,7 +27,7 @@ export default { | |||
| { odimCode: "behel", text: "Helchteren", latitude: 51.069199, longitude: 5.406138, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD' }, | |||
| { odimCode: "bejab", text: "Jabbeke", latitude: 51.1919, longitude: 3.0641, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD' }, | |||
| { odimCode: "bewid", text: "Wideumont", latitude: 49.9135, longitude: 5.5044, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD' }, | |||
| { odimCode: "bezav", text: "Zaventem", latitude: 50.9054, longitude: 4.4579, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD' }, | |||
| { odimCode: "bezav", text: "Zaventem", latitude: 50.9054, longitude: 4.4579, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD', showOnMap: true }, | |||
There was a problem hiding this comment.
Suggested change
| { odimCode: "bezav", text: "Zaventem", latitude: 50.9054, longitude: 4.4579, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD', showOnMap: true }, | |
| { odimCode: "bezav", text: "Zaventem", latitude: 50.9054, longitude: 4.4579, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD' }, |
For the INBO version of CROW, this can be removed. For ENRAM, I will add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue described at #201 by adding a new optional option (
hideOnMap) in the radar configuration.You can see an example with the "bezav" configuration below (I set it to false here so it's not hidden on INBO CROW site).
I guess the next step is to sync the
enram/crowrepo on this one, and addhideOnMapentries for the deprecated radars.Don't hesitate to ping me if you need help to do it, or if something doesn't work as expected!
Cheers