-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New mechanism to hide some radars from the selection map #202
base: main
Are you sure you want to change the base?
Conversation
Thanks @niconoe! To avoid negations, can I suggest |
Done, I negated the negation for a more positive outcome :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niconoe see my two suggestions
@@ -54,6 +54,7 @@ export interface RadarInterface { | |||
endpoint: string; // URL template, some variables are interpolated. Example: 'https://opendata.meteo.be/ftp/observations/radar/vbird/{odimCode}/{yyyy}/{odimCode}_vpts_{yyyymmdd}.txt' | |||
vptsFileFormat: VPTSFileFormat; | |||
heights: number[]; // Data is available at the following heights | |||
showOnMap?: boolean; // If false, the radar will not be displayed on the map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
showOnMap?: boolean; // If false, the radar will not be displayed on the map | |
showOnMap?: boolean; // If false, the radar will not be displayed on the map (default true) |
Note is the ?
intentional?
@@ -27,7 +27,7 @@ export default { | |||
{ odimCode: "behel", text: "Helchteren", latitude: 51.069199, longitude: 5.406138, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD' }, | |||
{ odimCode: "bejab", text: "Jabbeke", latitude: 51.1919, longitude: 3.0641, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD' }, | |||
{ odimCode: "bewid", text: "Wideumont", latitude: 49.9135, longitude: 5.5044, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD' }, | |||
{ odimCode: "bezav", text: "Zaventem", latitude: 50.9054, longitude: 4.4579, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD' }, | |||
{ odimCode: "bezav", text: "Zaventem", latitude: 50.9054, longitude: 4.4579, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD', showOnMap: true }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ odimCode: "bezav", text: "Zaventem", latitude: 50.9054, longitude: 4.4579, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD', showOnMap: true }, | |
{ odimCode: "bezav", text: "Zaventem", latitude: 50.9054, longitude: 4.4579, timezone: "Europe/Brussels", endpoint: meteoBeUrlTemplate, heights: availableHeights, vptsFileFormat: 'VOL2BIRD' }, |
For the INBO version of CROW, this can be removed. For ENRAM, I will add it.
This solves the issue described at #201 by adding a new optional option (
hideOnMap
) in the radar configuration.You can see an example with the "bezav" configuration below (I set it to false here so it's not hidden on INBO CROW site).
I guess the next step is to sync the
enram/crow
repo on this one, and addhideOnMap
entries for the deprecated radars.Don't hesitate to ping me if you need help to do it, or if something doesn't work as expected!
Cheers