Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sfp 115 nl #117

Merged
merged 29 commits into from
Jun 5, 2024
Merged

Sfp 115 nl #117

merged 29 commits into from
Jun 5, 2024

Conversation

hansvancalster
Copy link
Collaborator

Description

Related Issue

Task list

Steps by contributor:

  • Add description to this pull request (under "## Description")
  • Open the dropdown (triangle) near 'create pull request' and choose 'Create draft pull request'
  • Check for potential problems by running protocolhelper::check_frontmatter() and address them
  • Check for potential problems by running protocolhelper::check_structure() and address them
  • Add further commits if needed and push them to GitHub
  • Update the protocol-specific NEWS.Rmd
  • Mark the pull request as 'ready for review'

Review steps for the author(s):

  • Add reviewers, at least one subject-matter specialist and one administrator
  • Wait for review comments and address them
  • Iterate until reviewer approvals (merging the pull request will be done by an administrator)
  • Verify that the checks done by continuous integration succeeded. These will check if protocolhelper::check_frontmatter() and protocolhelper::check_structure() succeeded without errors.

To be done by an administrator after review: see guidelines for admins.

Florian9041 and others added 28 commits May 16, 2024 12:19
@Florian9041
sfp-115
6e960c7 
- template-hoofdstukken gegenereerd
- template-hoofdstukken ingevuld
- figuren toegevoegd
@Florian9041
onderwerp
06b18ea
@Florian9041
cross-referenties en andere verwijzingen bijgewerkt
fb453a7
@Florian9041
Bumped 2024.07 to 2024.04 in index.Rmd and NEWS.md
553efdb
@Florian9041
Referenties {.unnumbered}
7dca5d2
@Florian9041
Merge branch 'main' of https://github.com/inbo/protocolsource into sf…
735795b 
…p-115-nl
@Florian9041
Output directory aangepast (no connection bij render protocol)
e86e926
@Florian9041
Wijziging output directory teruggezet
b874a19
@Florian9041
graden en micro-symbool
fdb892a
@Florian9041
error tinytex: gecompileerde files verwijderd
284cb00
@Florian9041
gecompileerde documenten
eb02944
@Florian9041
debug tinytex error: gecompileerde documenten verwijderd
263e8f3
@Florian9041
tinytex-error opgelost: "µ" en "°" - symbolen toegevoegd, pdf gecompi…
304e6a6 
…leerd
@Florian9041
Afhankelijkheden toegevoegd (mr wss beter weglaten)
ab0bb24
@Florian9041
Inhoudelijke opmerkingen en verwijzingen aangepast
c833242
@Florian9041
Verwijzing naar staalnameformulier in bijlage svp-116
92e91c1
@Florian9041
Merge branch 'main' of https://github.com/inbo/protocolsource into sf…
b16ed8d 
…p-115-nl
@Florian9041
Verwijzing naar SVP-114 in index toegevoegd
e8a4725
@hansvancalster
Update source/sfp/1_water/sfp_115_nl_abiotiek_multimeter/_bookdown.yml
b23a0ef
@hansvancalster
Update source/sfp/1_water/sfp_115_nl_abiotiek_multimeter/02_onderwerp…
30dba0c 
….Rmd
@hansvancalster
Update source/sfp/1_water/sfp_115_nl_abiotiek_multimeter/03_beperking…
2bd4fd1 
…en.Rmd
@hansvancalster
Update source/sfp/1_water/sfp_115_nl_abiotiek_multimeter/05_competent…
853675a 
…ies.Rmd
@hansvancalster
Update source/sfp/1_water/sfp_115_nl_abiotiek_multimeter/07_werkwijze…
3e469ff 
….Rmd
@hansvancalster
Update source/sfp/1_water/sfp_115_nl_abiotiek_multimeter/07_werkwijze…
c778f14 
….Rmd
update general NEWS.md
1f099de
@hansvancalster
haakje
ae5591c
@hansvancalster
try to fix latex problems
b9d9b35
@hansvancalster
Merge branch 'main' of https://github.com/inbo/protocolsource into sf…
ae95955 
…p-115-nl
ElsLommelen
ElsLommelen approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@ElsLommelen ElsLommelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evt. zou je kunnen overwegen om commit b9d9b35 terug ongedaan te maken nu het probleem met de single quotes opgelost is, maar die beslissing laat ik aan u over.

@hansvancalster hansvancalster merged commit bb4bd25 into main Jun 5, 2024
3 checks passed
@hansvancalster hansvancalster deleted the sfp-115-nl branch June 5, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElsLommelen ElsLommelen ElsLommelen approved these changes

@Florian9041 Florian9041 Florian9041 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hansvancalster @ElsLommelen @Florian9041