Gorm upgrade to 1.25 and tweaks #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Generate unique savepoint names * Add a test for deeply nested wrapped transactions
* Use official SQL Server docker image for tests * Try with tag 2019-latest instead of latest * Use platform ubuntu-20.04 for SQL Server * Switch to 2019-CU18-ubuntu-20.04 * Check with 2022-latest image tag and ubuntu-latest platform * Update health-cmd * Try sqlcmd without -N -C * Re-include -N -C, try with ubuntu-20.04 * Try ubuntu-20.04 without -N -C (last trial) * Finalize working config * Remove unused env variables
…shes (go-gorm#7209) * feat(workflows): add GitHub Action to create release on new tag This workflow automates the release creation process whenever a new tag is pushed to the repository. It checks if a release for the tag already exists and creates one if it doesn't, enhancing the release management and streamlining the deployment process. * test * fix(workflow): improve release existence check in release-on-tag.yml Refactor the script to improve checking for existing releases by tag. Return an object instead of using core.setOutput to streamline the workflow logic. Also, set result-encoding to string for better compatibility. * fix(workflow): correct output handling in release-on-tag.yml Corrected the output handling in the 'release-on-tag.yml' workflow file by changing 'result-encoding' to 'outputs'. This ensures that the step correctly checks if a release exists before attempting to create a new one, thereby avoiding potential errors during the release process. Added a blank line for better readability. * fix(workflow): correct output setting in release-on-tag workflow Refactored how the release_exists output is set to be compatible with GitHub Actions syntax. This ensures the workflow reliably detects if a release already exists, improving the robustness of the release process. * fix(release): correct output handling in release-on-tag workflow Improved the way outputs are managed in the 'check_release' step by returning values instead of direct assignments. This change ensures better handling of release existence checks and improves code readability. Added 'result-encoding' to specify string encoding for results. * fix(workflow): correct release existence check and add debug output Refactored the release existence check to return a simple boolean string ('true'/'false') rather than an object. Added a step to print the release existence status for debugging purposes. This ensures correct conditional evaluation and aids in troubleshooting workflow issues. * fix(workflow): simplify release process by removing redundant checks The release-on-tag workflow has been streamlined by eliminating the redundant steps checking for existing releases. This change reduces complexity and speeds up the release process by directly creating a release on every tag push without prior existence verification.
… broken this for us and at least one other person.
henryjcee
commented
Oct 9, 2024
| @@ -922,7 +923,7 @@ func (field *Field) setupValuerAndSetter() { | |||
| if !reflectV.IsValid() { | |||
| field.ReflectValueOf(ctx, value).Set(reflect.New(field.FieldType).Elem()) | |||
| } else if reflectV.Kind() == reflect.Ptr && reflectV.IsNil() { | |||
| return | |||
There was a problem hiding this comment.
I will raise a PR on the upstream for this. Once this is resolved I think we can go back to depending on the upstream version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.