Skip to content

Commit

Permalink
reorganized components
Browse files Browse the repository at this point in the history
  • Loading branch information
ryyu444 committed May 14, 2024
1 parent 1afa4e2 commit 4c05759
Show file tree
Hide file tree
Showing 9 changed files with 30 additions and 27 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ As you make changes to your project, you likely want to see them update live. Ou

1. Make sure you're in the right directory with folders like src, public, etc.
2. In your terminal, type `npm i` to **install all the necessary dependencies** for the project.
3. Navigate to ```next.config.mjs and edit the basePath``` to be your ```repository name```.
- **We will also need to add this basePath to every image that we intend to use and localhost url.**
3. Navigate to ```next.config.mjs``` **edit the basePath** to be your ```repository name```.
- **We will also need to add this basePath to every image that we intend to use and localhost url. VERY IMPORTANT**
4. Now, you can run the app with `npm run dev` to **launch a development session**, which comes with its own localhost url!
- Changes automatically refresh the app
- Any errors will be displayed for you to debug
Expand Down
2 changes: 0 additions & 2 deletions src/app/layout.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import type { Metadata } from "next";
import { Inter } from "next/font/google";
import Navbar from "@/components/Navbar/Navbar";
import Footer from "@/components/Footer/Footer";
import NavLinks from "@/data/navLinks.json";
import "@/globals/globals.scss";

Expand All @@ -22,7 +21,6 @@ export default function RootLayout({
<body className={inter.variable}>
<Navbar navLinks={NavLinks} />
{children}
<Footer navLinks={NavLinks} />
</body>
</html>
);
Expand Down
12 changes: 8 additions & 4 deletions src/app/page.tsx
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
import Hero from "@/components/Hero/Hero";
import About from "@/components/About/About";
import Skills from "@/components/Skills/Skills";
import Projects from "@/components/Projects/Projects";
import ProjectsData from "@/data/projects.json";
import styles from "./page.module.scss";
import Contact from "@/components/Contact/Contact";

// need to add refs to the components

export default function Home() {
return (
<>
<Hero />
<div className={styles.Home}>
<About />
<Skills />
<Projects projects={ProjectsData} />
</>
<Contact />
</div>
);
}
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import styles from "./Hero.module.scss";
import styles from "./About.module.scss";

// add title, description, personal image, and resume button

export default function Hero() {
export default function About() {
return (
<section>
<div className={styles.hero}>
<div className={styles.About}>
<h1>My Portfolio</h1>
<p>Simple and clean portfolio website</p>
</div>
Expand Down
File renamed without changes.
11 changes: 11 additions & 0 deletions src/components/Contact/Contact.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import styles from "./Contact.module.scss";

// have social media icons & links + made with love by me

export default function Contact() {
return (
<section className={styles.Contact}>
<p>Contact</p>
</section>
);
}
10 changes: 0 additions & 10 deletions src/components/Footer/Footer.tsx

This file was deleted.

12 changes: 6 additions & 6 deletions src/data/navLinks.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
[
{
"name": "Home",
"slug": "/"
"name": "About",
"slug": "about-ref"
},
{
"name": "About",
"slug": "/about"
"name": "Skills",
"slug": "skills-ref"
},
{
"name": "Contact",
"slug": "/contact"
"name": "Projects",
"slug": "projects-ref"
}
]

0 comments on commit 4c05759

Please sign in to comment.