Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix the service worker console error #1553

Merged
merged 5 commits into from
Sep 19, 2023
Merged

fix: fix the service worker console error #1553

merged 5 commits into from
Sep 19, 2023

Conversation

cindyli
Copy link
Contributor

@cindyli cindyli commented Sep 18, 2023

  • This pull request has been linted by running npm run lint without errors
  • This pull request has been tested by running npm run start and reviewing affected routes
  • This pull request has been built by running npm run build without errors
  • This isn't a duplicate of an existing pull request

Description

Fix #1277.

Steps to test

  1. Open the console log, reload the page.

Expected behavior:
The error about the service-worker.js is not found should disappear.

greatislander
greatislander requested changes Sep 19, 2023
View reviewed changes
src/_includes/globals/service-worker.njk Outdated Show resolved Hide resolved
src/_includes/layouts/base.njk Outdated Show resolved Hide resolved
@greatislander greatislander mentioned this pull request Sep 19, 2023
Closed
4 tasks
@greatislander greatislander merged commit fdaed7d into inclusive-design:dev Sep 19, 2023
@github-actions github-actions bot mentioned this pull request Mar 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greatislander greatislander greatislander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service Worker caching incorrectly
2 participants
@cindyli @greatislander