IWF-357: Address MR comments

indeedeng · Jan 6, 2025 · 1f3c0dc · 1f3c0dc
1 parent c5df9ca
commit 1f3c0dc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/iwf/communication.py b/iwf/communication.py
@@ -80,9 +80,9 @@ def get_to_trigger_state_movements(self) -> list[StateMovement]:
         return self._state_movements
 
     def get_internal_channel_size(self, channel_name):
-        registered_type = self._internal_channel_type_store.get_type(channel_name)
+        is_type_registered = self._internal_channel_type_store.is_valid_name_or_prefix(channel_name)
 
-        if registered_type is None:
+        if is_type_registered is False:
             raise WorkflowDefinitionError(
                 f"InternalChannel channel_name is not defined {channel_name}"
             )

diff --git a/iwf/type_store.py b/iwf/type_store.py
@@ -36,7 +36,7 @@ def get_type(self, name: str) -> Optional[type]:
 
     def add_internal_channel_def(self, obj: CommunicationMethod):
         if self._class_type != Type.INTERNAL_CHANNEL:
-            raise WorkflowDefinitionError(
+            raise ValueError(
                 f"Cannot add internal channel definition to {self._class_type}"
             )
         self._do_add_to_store(obj.is_prefix, obj.name, obj.value_type)