Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug #125 (dataclasses for expressions) #147

Closed
wants to merge 18 commits into from

Conversation

matthiasdiener
Copy link
Contributor

@matthiasdiener matthiasdiener commented Sep 20, 2024

attrs: #125

@alexfikl
Copy link
Collaborator

FWIW, tried some of this in inducer/pytential#223. I tried to use pytest-memray to see which tests use the most memory, but didn't get anywhere..

@matthiasdiener matthiasdiener changed the title Debug attrs ci Debug #125 (dataclasses for expressions) Sep 23, 2024
@matthiasdiener
Copy link
Contributor Author

matthiasdiener commented Sep 23, 2024

It seems the problem is that too many warnings are issued 😵‍💫 ....

I was not able to run all of pytential's pytests with all of the warnings enabled, even locally; from just running some of the tests, the total number of warnings that I disabled in a433807 must be in the millions...

What we could do is:

@inducer

@inducer
Copy link
Owner

inducer commented Sep 23, 2024

It seems the problem is that too many warnings are issued 😵‍💫 ....

OMG! That makes so much sense, but it never occurred to me. 🤦

@inducer
Copy link
Owner

inducer commented Sep 23, 2024

The latest update to #125 drops the stacklevels on these to 1, which should result in a big reduction in the duplication of these warnings.

@alexfikl
Copy link
Collaborator

Well.. 🤯 Amazing catch!

@matthiasdiener
Copy link
Contributor Author

Closing, #125 appears to work now.

@matthiasdiener matthiasdiener deleted the debug-attrs-ci branch September 24, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants