-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup build wheels using cibuildwheel for all systems #559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, much appreciated! Could you make it so that this gets rid of the existing wheel build infrastructure? (entry in ci.yml
plus associated scripts)
I've just tested if the wheels in this artifact install and work on one of my Windows machines. I testet python 3.9 and 3.10: Both work nicely. I'm so happy to see this happening here! It's a huge relief. Thanks so much for working on this! Best, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Just a few notes below, then this should be ready to go.
Co-authored-by: Andreas Klöckner <[email protected]>
add missed SCRIPT_DIR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for seeing this through! Assuming we can get the CI to pass, I'd be OK with merging this. @isuruf, any remaining concerns?
Co-authored-by: Andreas Klöckner <[email protected]>
Tried a wheel, seems to work for me. I think this is a better way than what we had, with far better platform coverage. So let's go for it. Thanks @Czaki for working on this! |
Quite possibly I should roll a release to try all this out, so let's do that. :) |
Looks like that worked: https://pypi.org/project/pyopencl/2022.1.4/#files 🎉 Thanks again! |
I also tried this morning and I'm super happy that this works now. Thanks everyone! 🥳 |
Building wheel on Linux for manylinux and pypy. Configuration for muslinux is prepared, but not enabled because lack of OpenCL bindings in the stable channels (if there is a need for such wheels then I think it will be possible to build it from the source). Tests on Linux is disabled because of a lack of OpenCL compatible device on the host system.
For macOS, pypy wheels are disabled because of the problem with building NumPy from the source
For windows, only 64 bits wheels are built because 32 bits build wheels fail with linker errors. Tests are disabled, One needs to test weels manually on the device with openCL.
Building wheel procedure for MacOS and Windows is based on conda-forge one.
close #488