Array context

[inducer]

Clone of https://gitlab.tiker.net/inducer/pytential/-/merge_requests/198 for review.

cc @mattwala @alexfikl

[inducer]

@mattwala There are still a few unresolved items here. Do you think you'll have time to work on them, or would you like me to?

[mattwala]

@mattwala There are still a few unresolved items here. Do you think you'll have time to work on them, or would you like me to?

I didn't see them. I thought everything had been resolved. I will work on them.

[inducer]

Thanks! LGTM. Closing here, finishing up on Gitlab.

[inducer]

@isuruf After the Apple CI on Gitlab CI (on Appletini, stuck on an old version of the OS) started failing with nonsense, I decided I would try my luck here, but I'm kind of stuck. If you have some thoughts, I'd be happy to hear them.

The failures on 5fe6d92 and ba588a6 are probably more relevant than the last one.

If you have time to take a look: Thanks!

[inducer]

@isuruf Thanks! (Also invited you to the repo, just in case.)

[isuruf]

The failure on Appletini is an issue with clang 10 and 9 and was fixed in master. (pocl latest build was built with clang 10) 10.0.1 is around the corner. As a workaround, let me see if an updated ld64 works with clang 10. (ld64 530 was recently open sourced by Apple)

[inducer]

The failure on Appletini is an issue with clang 10 and 9 and was fixed in master.

Thanks for the tip!

I'm guessing you mean clang master? Do you have a bug link by any chance?

At any rate, that's good to know. However since Appletini can no longer get the latest OS updates, I'm not super eager to keep it going much longer anyway, so this move is something I was wanting to do anyway. The failure just accelerated the schedule a bit.

[isuruf]

I'm guessing you mean clang master?

Yes

Do you have a bug link by any chance?

https://bugs.llvm.org/show_bug.cgi?id=44813

[inducer]

https://bugs.llvm.org/show_bug.cgi?id=44813

Thanks!

Closing here, wrapping up on Gitlab.