Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PyOxidizer build local rust project when it can find toml file #700

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JulianZhang
Copy link

I am planning to mix Rust and Python in a new project. When I tried to build the demo project with cargo build , I found that the add_python_resource step was missing, causing some dependency files to be missing when running Python scripts. Using pyoxidizer build can create the correct Python runtime environment, but it always compiles the demo Rust project.

I found that the easiest solution is to modify some of the PyOxidizer code so that when there is a local project, it compiles the local project instead of creating a new demo. The current condition I have chosen is to find a toml file in the current working directory (CWD).

Can this change be considered for merging into the main branch?

@JulianZhang JulianZhang changed the title Make PyOxidizer build local rust project when it can file toml file Make PyOxidizer build local rust project when it can find toml file May 18, 2023
@JulianZhang
Copy link
Author

@indygreg Hi, I thank PyOxidizer is ready to build python env with user's rust project. And I also find there is another PR with same requirement 468.

But the 468 was blocked because failed in checks. If you thank the solution by 468 (use env) is better, I can write a new PR use that way, and fix all checking fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant