Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tugger-wix: Make msi option to add to path env optional. #711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewleech
Copy link

When building / installing a GUI application, it's less common to want the install folder added to system env PATH.
This PR makes the inclusion of this checkbox in the msi installer optional, though enabled by default to not effect existing users.

Used like:

def make_msi(exe):
    msi = exe.to_wix_msi_builder(
        "wsl_usb_gui",
        "WSL USB",
        VARS.get("version"),
        "Andrew Leech"
    )
    msi.add_to_path = False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants