error: incorrect implementation of `partial_cmp` on an `Ord` type --> apple-sdk/src/lib.rs:438:1 | 438 | / impl PartialOrd for PlatformDirectory { 439 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 440 | || self.path.partial_cmp(&other.path) 441 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 442 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type = note: `#[deny(clippy::incorrect_partial_ord_impl_on_ord_type)]` on by default

error: incorrect implementation of `partial_cmp` on an `Ord` type --> apple-sdk/src/lib.rs:817:1 | 817 | / impl PartialOrd for SdkVersion { 818 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 819 | || let a = self.normalized_version().unwrap_or((0, 0, 0)); 820 | || let b = other.normalized_version().unwrap_or((0, 0, 0)); 821 | || 822 | || a.partial_cmp(&b) 823 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 824 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type

error: incorrect implementation of `partial_cmp` on an `Ord` type --> apple-codesign/src/code_requirement.rs:100:1 | 100 | / impl PartialOrd for RequirementType { 101 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 102 | || u32::from(*self).partial_cmp(&u32::from(*other)) 103 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 104 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type = note: `#[deny(clippy::incorrect_partial_ord_impl_on_ord_type)]` on by default

error: incorrect implementation of `partial_cmp` on an `Ord` type --> apple-codesign/src/code_resources.rs:524:1 | 524 | / impl PartialOrd for CodeResourcesRule { 525 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 526 | || // Default weight is 1 if not specified. 527 | || let our_weight = self.weight.unwrap_or(1); 528 | || let their_weight = other.weight.unwrap_or(1); ... || 536 | || } 537 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 538 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type

error: incorrect implementation of `partial_cmp` on an `Ord` type --> apple-codesign/src/embedded_signature.rs:256:1 | 256 | / impl PartialOrd for CodeSigningSlot { 257 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 258 | || u32::from(*self).partial_cmp(&u32::from(*other)) 259 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 260 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type

error: incorrect implementation of `partial_cmp` on an `Ord` type --> apple-codesign/src/embedded_signature.rs:371:1 | 371 | / impl PartialOrd for DigestType { 372 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 373 | || u8::from(*self).partial_cmp(&u8::from(*other)) 374 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 375 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy@master. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

warning: unneeded unit expression --> apple-xar/src/format.rs:14:38 | 14 | #[derive(Clone, Copy, Debug, IOread, IOwrite, Pread, SizeWith)] | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default = note: this warning originates in the derive macro `IOwrite` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unneeded unit expression --> apple-bom/src/format.rs:154:39 | 154 | #[derive(Clone, Copy, Default, Debug, IOwrite, Pread, Pwrite, SizeWith)] | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default = note: this warning originates in the derive macro `IOwrite` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unneeded unit expression --> apple-bom/src/format.rs:266:39 | 266 | #[derive(Clone, Copy, Default, Debug, IOwrite, Pread, Pwrite, SizeWith)] | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: this warning originates in the derive macro `IOwrite` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unneeded unit expression --> apple-bom/src/format.rs:406:39 | 406 | #[derive(Clone, Copy, Default, Debug, IOwrite, Pread, Pwrite, SizeWith)] | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: this warning originates in the derive macro `IOwrite` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unneeded unit expression --> apple-bom/src/format.rs:470:39 | 470 | #[derive(Clone, Copy, Default, Debug, IOwrite, Pread, Pwrite, SizeWith)] | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: this warning originates in the derive macro `IOwrite` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unneeded unit expression --> apple-bom/src/format.rs:622:39 | 622 | #[derive(Clone, Copy, Default, Debug, IOwrite, Pread, Pwrite, SizeWith)] | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: this warning originates in the derive macro `IOwrite` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unneeded unit expression --> apple-bom/src/format.rs:657:39 | 657 | #[derive(Clone, Copy, Default, Debug, IOwrite, Pread, Pwrite, SizeWith)] | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: this warning originates in the derive macro `IOwrite` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unneeded unit expression --> apple-bom/src/format.rs:804:30 | 804 | #[derive(Clone, Copy, Debug, IOwrite, Pwrite, SizeWith)] | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: this warning originates in the derive macro `IOwrite` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unneeded unit expression --> apple-bom/src/format.rs:935:39 | 935 | #[derive(Clone, Copy, Default, Debug, IOwrite, Pread, Pwrite, SizeWith)] | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: this warning originates in the derive macro `IOwrite` (in Nightly builds, run with -Z macro-backtrace for more info)