Skip to content

Commit

Permalink
apple-codesign: zip 0.6 -> 2.2
Browse files Browse the repository at this point in the history
Required a minor code change due to an API change.
  • Loading branch information
indygreg committed Nov 2, 2024
1 parent 52a77fc commit 49b92a2
Show file tree
Hide file tree
Showing 4 changed files with 61 additions and 7 deletions.
57 changes: 54 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions apple-codesign/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Released on ReleaseDate.
* `widestring` 1.0 -> 1.1.
* `x509-certificate` 0.23 -> 0.24.
* `zeroize` 1.7 -> 1.8.
* `zip` 0.6 -> 2.2.

## 0.27.0

Expand Down
4 changes: 2 additions & 2 deletions apple-codesign/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ xml-rs = "0.8.22"
yasna = "0.5.2"
yubikey = { version = "0.8.0", optional = true, features = ["untested"] }
zeroize = { version = "1.8.1", features = ["zeroize_derive"] }
zip = { version = "0.6.6", default-features = false, features = ["deflate"] }
zip = { version = "2.2.0", default-features = false, features = ["deflate"] }
zip_structs = "0.2.1"

[dependencies.app-store-connect]
Expand Down Expand Up @@ -117,7 +117,7 @@ indoc = "2.0.5"
simple-file-manifest = "0.11.0"
tar = "0.4.43"
trycmd-indygreg-fork = "0.14.20"
zip = { version = "0.6.6", default-features = false }
zip = { version = "2.2.0", default-features = false }

[features]
default = ["notarize"]
Expand Down
6 changes: 4 additions & 2 deletions apple-codesign/src/notarization.rs
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ pub fn bundle_to_zip(bundle: &DirectoryBundle) -> Result<Vec<u8>, AppleCodesignE
let name =
format!("{}/{}", bundle.name(), file.relative_path().display()).replace('\\', "/");

let options = zip::write::FileOptions::default();
let options = zip::write::SimpleFileOptions::default();

let options = if entry.link_target().is_some() {
symlinks.push(name.as_bytes().to_vec());
Expand Down Expand Up @@ -432,7 +432,9 @@ impl Notarizer {
Ok(status)
}

pub fn list_submissions(&self) -> Result<notary_api::ListSubmissionResponse, AppleCodesignError> {
pub fn list_submissions(
&self,
) -> Result<notary_api::ListSubmissionResponse, AppleCodesignError> {
Ok(self.client()?.list_submissions()?)
}
}

0 comments on commit 49b92a2

Please sign in to comment.