feat: add support for proxy auth #88
Conversation
|
Also note the Cargo.lock was not committed as part of this PR. |
|
@roblabla I left out a comma when trying to copy and paste from our internal environment (oops) and ended up failing the build workflows. Fixed now |
There was a problem hiding this comment.
This PR has been bit rotted against our main branch. I attempted to rebase it. But it isn't clear to me how the new proxy code works in aws-smithy 0.57, which refactored things: smithy-lang/smithy-rs#3022.
I'm also a bit concerned about the presence of the ~2 year old hyper-proxy 0.9.1. It appears this version is pulling in very old versions of various crates, including an older version of ring and rustls.
I may look at this again in a day or two with a fresh brain. But if the original authors want to clean it up and get it working with aws-smithy 0.57, it would be greatly appreciated.
The PR can be rebased against the main branch, as the certificates changes related to this PR were merged into main a few hours ago.
This allows using the same version of rustls betwen apple-codesign and the AWS SDK, which allows enabling the native-tls features of rustls inside the S3 client.
austinsasko
force-pushed
the
feat/support-proxy-auth
branch
from
3da04ae to
233d114
Compare
|
@indygreg I think I was able to clean it up and apply your feedback. Please let me know |
|
It seems I messed up a few things in the merge conflict. Will push an update that I tested the fix on tomorrow. |
|
Tested build, run, and OS X + Ubuntu binary locally from a corp proxy environment and non-corp proxy environment. Success on all fronts. |
|
@indygreg Are these workflows failing due to issues with my PR, do you have any insight into that? |
|
The nightly failure can probably be fixed by updating the time dependency, with The 1.70 failure, I'm not sure. Might be worth updating the smithy crates, see if that fixes the issues? |
|
That helped with 3 of the builds, thanks! will try what you suggested on the other 6, feels we are so close! |
Support added for proxy authentication. This does not add tests to validate proxy / noproxy use cases, nor is this validated against non proxy environments, but is fully functional in a corporate proxy-backed environment.
Co-Authors: @cbacken / https://github.com/cbacken