Skip to content

Commit

Permalink
debian-packaging: remove http conditional on url error
Browse files Browse the repository at this point in the history
The url crate is always enabled. And we use it in non-conditional
code. We need the error variant to always be present.

While we're here add CI coverage for building with no default
features to keep us honest.
  • Loading branch information
indygreg committed Nov 2, 2024
1 parent 1b12bbb commit 4a26fb1
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/workspace.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jobs:
RUSTC_WRAPPER: sccache
run: |
rustc --version
cargo build --workspace --no-default-features
cargo build --workspace
cargo nextest run --no-run --workspace
Expand Down
1 change: 1 addition & 0 deletions debian-packaging/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

Released on ReleaseDate.

* Fixed compile error when building without the `http` feature.
* MSRV 1.70 -> 1.75.
* `async-std` 1.12 -> 1.13.
* `async-tar` 0.4 -> 0.5.
Expand Down
1 change: 0 additions & 1 deletion debian-packaging/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ pub enum DebianError {
#[error("file manifest error: {0}")]
FileManifestError(#[from] FileManifestError),

#[cfg(feature = "http")]
#[error("URL error: {0:?}")]
Url(#[from] url::ParseError),

Expand Down

0 comments on commit 4a26fb1

Please sign in to comment.