-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Fix resolving shared dot props #636
[1.x] Fix resolving shared dot props #636
Conversation
Same comment as in #634 (comment). Might be worth investigation if the PR #631 also solve this issue? |
Alright, too bad. Thanks for confirming. Sure, in what way? That PR simply reverted back the method "resolvePropertyInstances" to what it previously was |
@reinink I rewrote the entire partial request resolving logic. It seems that the only way to support nested partial props without introducing any breaking changes is to check each prop independently to determine whether it should be included or excluded from the partial response. Additionally, we need to resolve dot-notated props last to ensure they are merged after any parent closures are resolved. |
Based on #634
This PR includes extra tests to ensure shared props can be included and excluded from partial responses.