Merge pull request #653 from edli/dev

fix(normalization): issue-648, remove props.key and props.ref

src/core/__tests__/normalizeProps.spec.tsx

@@ -0,0 +1,39 @@
+import { expect } from 'chai';
+import { normalize } from '../normalization';
+import { VNode } from '../structures';
+
+describe('normalizeProps', () => {
+	it('should delete ref from props', () => {
+		const vNode: VNode = {
+			children: null,
+			dom: null,
+			events: null,
+			flags: 0,
+			key: null,
+			props: { ref: () => {} },
+			ref: null,
+			type: null
+		};
+
+		normalize(vNode);
+
+		expect(vNode.props).to.not.have.property('ref');
+	});
+
+	it('should delete key from props', () => {
+		const vNode: VNode = {
+			children: null,
+			dom: null,
+			events: null,
+			flags: 0,
+			key: null,
+			props: { key: 'key' },
+			ref: null,
+			type: null
+		};
+
+		normalize(vNode);
+
+		expect(vNode.props).to.not.have.property('key');
+	});
+});

src/core/normalization.ts

@@ -88,16 +88,15 @@ function normalizeProps(vNode: VNode, props: Props, children: InfernoChildren) {
 		vNode.children = props.children;
 	}
 	if (props.ref) {
+		vNode.ref = props.ref;
 		delete props.ref;
 	}
-	if (props.key) {
-		delete props.key;
-	}
 	if (props.events) {
 		vNode.events = props.events;
 	}
 	if (!isNullOrUndef(props.key)) {
 		vNode.key = props.key;
+		delete props.key;
 	}
 }