Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: seamlessly retry requests on backend failure for the Elasticsearch filter #63

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

medcl
Copy link
Member

@medcl medcl commented Jan 15, 2025

What does this PR do

Previously, when one of the nodes was down, any requests sent to that node— including read requests—would fail. Recovery would only occur after the node received enough failure tickets or reached the refresh interval, which could take significant time. This delay often led to numerous failed requests, even when backup nodes were available to handle them.

With this change, requests are seamlessly retried with other nodes by default, minimizing interruptions and improving reliability.

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@medcl medcl changed the title feat: allow to seamless retry on backend failure feat: seamlessly retry requests on backend failure for the Elasticsearch filter Jan 15, 2025
@medcl medcl marked this pull request as draft January 15, 2025 07:36
@medcl medcl marked this pull request as ready for review January 15, 2025 07:44
@silenceqi silenceqi merged commit 8cd9c85 into main Jan 15, 2025
4 checks passed
@medcl medcl deleted the seamless_retry branch January 15, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants