Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code format check #14

Merged
merged 6 commits into from
Jan 15, 2025
Merged

chore: code format check #14

merged 6 commits into from
Jan 15, 2025

Conversation

luohoufu
Copy link
Contributor

What does this PR do

code format check

Rationale for this change

This pull request includes several changes to the .github/workflows/pr-check.yml file to add a new job for format checking and modifies some existing job configurations. Additionally, it removes some constants from the config/generated.go file.

Workflow improvements:

  • .github/workflows/pr-check.yml: Added a new format_check job that includes steps for setting up the Go toolchain, running make format, and checking for changes after formatting. If changes are detected, the workflow will fail.
  • .github/workflows/pr-check.yml: Removed the fetch-depth parameter from the Checkout current repository, Checkout framework repository, and Checkout framework-vendor steps in the unit_test job.

Code cleanup:

  • config/generated.go: Removed unused constants LastCommitLog, BuildDate, EOLDate, Version, and BuildNumber.

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

.github/workflows/pr-check.yml Outdated Show resolved Hide resolved
.github/workflows/pr-check.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@luohoufu luohoufu requested a review from SteveLauC January 14, 2025 06:47
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI part looks good to me, but I am not sure about the .gitignore part because I am not familiar with the runtime files that Loadgen would generate so I will leave it up to @medcl

@SteveLauC SteveLauC merged commit b6bd49a into main Jan 15, 2025
5 checks passed
@SteveLauC SteveLauC deleted the pr_code_format branch January 15, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants