Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: continue_next should be true by default #4

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: continue_next should be true by default #4

merged 1 commit into from
Dec 10, 2024

Conversation

medcl
Copy link
Member

@medcl medcl commented Dec 10, 2024

This pull request includes several changes to the loader.go file to improve logging, error handling, and debugging capabilities. The most important changes include fixing a typo in an error message, adding additional logging for assertion failures, modifying the return values of a function, and enhancing debug logging.

Improvements to logging and error handling:

  • Fixed a typo in the error message from "whilte" to "while" in the doRequest function.
  • Added an informational log message when an assertion fails and subsequent requests are skipped.

Enhancements to function return values and debugging:

  • Changed the return values of the doRequest function to return a boolean and an error instead of just returning.
  • Added the index variable i to the loop over config.Requests in the Run function to facilitate better logging.
  • Enhanced debug logging in the Run function to include the request index, continuation status, and error details.

Copy link
Contributor

@luohoufu luohoufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@medcl medcl merged commit fae18a5 into main Dec 10, 2024
2 checks passed
@medcl medcl deleted the cont branch December 10, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants