feat: allow to skip invalid assert conditions #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve error handling and reporting in the load testing framework. The most important changes include adding a new configuration option to skip invalid assertions, updating the statistics structure to differentiate between different types of assertion errors, and adding validation for requests during the warmup phase.
Closes #5
Improvements to error handling:
domain.go
: AddedSkipInvalidAssert
field toRunnerConfig
struct to allow skipping invalid assertions.Updates to statistics reporting:
loader.go
: ChangedNumInvalid
toNumAssertInvalid
and addedNumAssertSkipped
inLoadStats
struct to better categorize assertion errors.loader.go
: Updated error counting logic indoRequest
function to incrementNumAssertSkipped
ifSkipInvalidAssert
is enabled andNumAssertInvalid
otherwise. [1] [2]Request validation:
loader.go
: Added request validation inWarmup
function to log and panic on invalid requests.Updates to main loader logic:
main.go
: UpdatedstartLoader
andrunLoaderConfig
functions to handle new statistics fields and print detailed assertion error counts. [1] [2] [3]