New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shutdown of the cdk consumer #4273

Merged

fraidev merged 2 commits into infinyon:master from fraidev:fix_offset_consumer_shutdown

Nov 26, 2024

Contributor

fraidev commented Nov 25, 2024 •

edited

Loading

We're shutdown connectors with signal kill that couldn't be handled by the application.
I propose using SIGTERM that allows ctrlc package to handle with the graceful shutdown.

References:

https://www.gnu.org/software/libc/manual/html_node/Termination-Signals.html


          fix: shutdown of the cdk consumer

1f723bf

fraidev force-pushed the fix_offset_consumer_shutdown branch from e85feac to 1f723bf Compare

November 25, 2024 19:50

fraidev mentioned this pull request

fix: remove consumer stream from a loop to allow drop infinyon/sql-connector#144

Merged

fraidev marked this pull request as ready for review

November 25, 2024 19:53

fraidev requested review from digikata and sehz

November 25, 2024 19:59

digikata approved these changes

View reviewed changes

sehz approved these changes

View reviewed changes

fraidev added this pull request to the merge queue

github-merge-queue bot pushed a commit that referenced this pull request


          fix: shutdown of the cdk consumer (#4273)

2fb366b

fraidev removed this pull request from the merge queue due to a manual request

fraidev added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

fraidev added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

fraidev added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

fraidev added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks


          Merge branch 'master' into fix_offset_consumer_shutdown

17c894d

fraidev enabled auto-merge

November 25, 2024 23:51

fraidev added this pull request to the merge queue

fraidev removed this pull request from the merge queue due to a manual request

fraidev added this pull request to the merge queue

Merged via the queue into infinyon:master with commit ddcb063

107 checks passed

fraidev deleted the fix_offset_consumer_shutdown branch

November 26, 2024 01:57

fraidev mentioned this pull request

fix: shutdown of the cdk consumer by future not stream #4276

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet