-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move fbm to fluvio cli #4326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraidev
force-pushed
the
move_fbm_to_fluvio_cli
branch
2 times, most recently
from
January 16, 2025 01:23
0d4d9f9
to
a344dfb
Compare
fraidev
force-pushed
the
move_fbm_to_fluvio_cli
branch
6 times, most recently
from
January 16, 2025 02:14
07816f8
to
01ae166
Compare
sehz
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, is latency shown? if not can be added subsequent PR
No latency for now. I'll create a new PR for:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 16, 2025
fraidev
force-pushed
the
move_fbm_to_fluvio_cli
branch
from
January 16, 2025 02:57
01ae166
to
280f088
Compare
fraidev
force-pushed
the
move_fbm_to_fluvio_cli
branch
from
January 16, 2025 03:01
280f088
to
d7962fe
Compare
Closed
@fraidev don't forget to add this CLI to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples of usage:
Help:
Also on this pr was made a cleanup on producer benchmark