Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move fbm to fluvio cli #4326

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

fraidev
Copy link
Contributor

@fraidev fraidev commented Jan 14, 2025

Examples of usage:

fluvio bench producer
fluvio benchmark producer
fluvio benchmark producer --batch-size 1mb --num-records 100000 --linger 0ms --record-size 5kb
fluvio benchmark producer -h 

Help:

Run a producer benchmark

Usage: fluvio bench producer [OPTIONS]

Options:
  -b, --batch-size <bytes>
          [default: "16.4 KB"]
  -q, --queue-size <QUEUE_SIZE>
          [default: 10]
      --max-request-size <bytes>
          [default: "33.6 MB"]
  -l, --linger <LINGER>
          [default: 0ms]
      --server-timeout <SERVER_TIMEOUT>
          [default: 5000ms]
  -c, --compression <COMPRESSION>
          [default: none]
      --num-samples <NUM_SAMPLES>
          [default: 3]
      --time-between-samples <TIME_BETWEEN_SAMPLES>
          [default: 250ms]
      --worker-timeout <WORKER_TIMEOUT>
          [default: 3000s]
  -p, --partitions <PARTITIONS>
          [default: 1]
  -r, --replicas <REPLICAS>
          [default: 1]
  -t, --topic-name <TOPIC_NAME>
          [default: benchmark-ridwexhqjv]
  -d, --delete
          
      --ignore-rack
          
      --record-key-allocation-strategy <RECORD_KEY_ALLOCATION_STRATEGY>
          [default: no-key] [possible values: no-key, all-share-same-key, producer-worker-unique-key, random-key]
      --num-producers <NUM_PRODUCERS>
          [default: 1]
      --num-records <NUM_RECORDS>
          [default: 10000]
      --record-size <bytes>
          [default: "5.1 KB"]
  -h, --help
          Print help (see more with '--help')

Also on this pr was made a cleanup on producer benchmark

@fraidev fraidev force-pushed the move_fbm_to_fluvio_cli branch 2 times, most recently from 0d4d9f9 to a344dfb Compare January 16, 2025 01:23
@fraidev fraidev force-pushed the move_fbm_to_fluvio_cli branch 6 times, most recently from 07816f8 to 01ae166 Compare January 16, 2025 02:14
@fraidev fraidev requested a review from sehz January 16, 2025 02:29
@fraidev fraidev marked this pull request as ready for review January 16, 2025 02:29
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, is latency shown? if not can be added subsequent PR

@fraidev
Copy link
Contributor Author

fraidev commented Jan 16, 2025

Looks reasonable, is latency shown? if not can be added subsequent PR

No latency for now.

I'll create a new PR for:

  • add latency
  • run samples X times (same test config to print the average)
  • improve printing

@fraidev fraidev added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@fraidev fraidev added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@fraidev fraidev added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@fraidev fraidev force-pushed the move_fbm_to_fluvio_cli branch from 01ae166 to 280f088 Compare January 16, 2025 02:57
@fraidev fraidev force-pushed the move_fbm_to_fluvio_cli branch from 280f088 to d7962fe Compare January 16, 2025 03:01
@fraidev fraidev enabled auto-merge January 16, 2025 03:05
@fraidev fraidev added this pull request to the merge queue Jan 16, 2025
Merged via the queue into infinyon:master with commit 20448df Jan 16, 2025
102 checks passed
@fraidev fraidev deleted the move_fbm_to_fluvio_cli branch January 16, 2025 03:39
@fraidev fraidev mentioned this pull request Jan 16, 2025
@ajhunyady
Copy link
Contributor

@fraidev don't forget to add this CLI to fluvio-docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants