Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf improvement: implement async write for hw checkpoint #4335

Merged
merged 2 commits into from
Jan 17, 2025
Merged

perf improvement: implement async write for hw checkpoint #4335

merged 2 commits into from
Jan 17, 2025

Conversation

sehz
Copy link
Contributor

@sehz sehz commented Jan 17, 2025

Since HW write doesn't need to be sync with file, we can separate into asynchronous task.

Writer task is spawned to write to file which doesn't block checkpoint update.

@sehz sehz requested a review from fraidev January 17, 2025 05:27
fraidev
fraidev approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@fraidev fraidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sehz sehz added this pull request to the merge queue Jan 17, 2025
Merged via the queue into infinyon:master with commit de9339a Jan 17, 2025
102 checks passed
@sehz sehz deleted the sehz/perf_optimization branch January 17, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fraidev fraidev fraidev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sehz @fraidev