Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fluvio producer callback #4340

Merged
merged 5 commits into from
Jan 21, 2025
Merged

feat: add fluvio producer callback #4340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1617509
feat: add fluvio producer callback
fraidev Jan 20, 2025
16c33c3
chore: remove generic from producer callback
fraidev Jan 20, 2025
145d6aa
chore: return batch info via callback
fraidev Jan 20, 2025
59341e0
chore: remove interval latency for now
fraidev Jan 20, 2025
0e7380c
chore: getting response from the callback concurrently
fraidev Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 31 additions & 22 deletions crates/fluvio-benchmark/src/producer_benchmark.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,22 @@ impl ProducerBenchmark {
let mut workers_jh = Vec::new();

let (stat_sender, stat_receiver) = unbounded();
let (latency_sender, latency_receiver) = unbounded();
let (end_sender, end_receiver) = unbounded();

// Set up producers
for producer_id in 0..config.num_producers {
let (event_sender, event_receiver) = unbounded();
println!("starting up producer {}", producer_id);
let stat_collector = StatCollector::create(
config.batch_size.as_u64(),
config.num_records,
latency_sender.clone(),
end_sender.clone(),
stat_sender.clone(),
event_receiver,
);
let (tx_control, rx_control) = unbounded();
let worker = ProducerWorker::new(producer_id, config.clone(), stat_collector).await?;
let worker =
ProducerWorker::new(producer_id, config.clone(), stat_collector, event_sender)
.await?;
let jh = spawn(timeout(
config.worker_timeout,
ProducerDriver::main_loop(rx_control, worker),
Expand All @@ -76,35 +80,40 @@ impl ProducerBenchmark {

loop {
select! {
hist = latency_receiver.recv() => {
if let Ok(hist) = hist {
stat_rx = stat_receiver.recv() => {
if let Ok(stat) = stat_rx {
let human_readable_bytes = ByteSize(stat.bytes_per_sec).to_string();
println!(
//TODO: fix inteval latency
//"{} records sent, {} records/sec: ({}/sec), {:.2}ms avg latency, {:.2}ms max latency",
"{} records sent, {} records/sec: ({}/sec)",
stat.record_send, stat.records_per_sec, human_readable_bytes,
//utils::nanos_to_ms_pritable(stat.latency_avg), utils::nanos_to_ms_pritable(stat.latency_max)
);
}
}
end = end_receiver.recv() => {
if let Ok(end) = end {
let mut latency_yaml = String::new();
latency_yaml.push_str(&format!("{:.2}ms avg latency, {:.2}ms max latency",
utils::nanos_to_ms_pritable(hist.mean() as u64),
utils::nanos_to_ms_pritable(hist.value_at_quantile(1.0))));
utils::nanos_to_ms_pritable(end.histogram.mean() as u64),
utils::nanos_to_ms_pritable(end.histogram.value_at_quantile(1.0))));
for percentile in [0.5, 0.95, 0.99] {
latency_yaml.push_str(&format!(
", {:.2}ms p{percentile:4.2}",
utils::nanos_to_ms_pritable(hist.value_at_quantile(percentile)),
utils::nanos_to_ms_pritable(end.histogram.value_at_quantile(percentile)),
));
}
println!();
println!("{}", latency_yaml);
}
break;
}
stat_rx = stat_receiver.recv() => {
if let Ok(stat) = stat_rx {
// lantecy_receiver is finishing the benchmark now
//if stat.end {
// break;
//}
let human_readable_bytes = ByteSize(stat.bytes_per_sec as u64).to_string();

let human_readable_bytes = ByteSize(end.bytes_per_sec).to_string();
println!(
"{} records sent, {} records/sec: ({}/sec), {:.2}ms avg latency, {:.2}ms max latency",
stat.total_records_send, stat.records_per_sec, human_readable_bytes,
utils::nanos_to_ms_pritable(stat.latency_avg), utils::nanos_to_ms_pritable(stat.latency_max)
"{} total records sent, {} records/sec: ({}/sec) ",
end.total_records, end.records_per_sec, human_readable_bytes
);
}
break;
}
}
}
Expand Down
60 changes: 40 additions & 20 deletions crates/fluvio-benchmark/src/producer_worker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
use std::sync::Arc;

use anyhow::Result;

use async_channel::Sender;
use fluvio::{
dataplane::record::RecordData, DeliverySemantic, Fluvio, Isolation, RecordKey,
dataplane::record::RecordData, DeliverySemantic, Fluvio, Isolation,
ProduceCompletionBatchEvent, ProducerCallback, SharedProducerCallback, RecordKey,
TopicProducerConfigBuilder, TopicProducerPool,
};
use futures_util::future::BoxFuture;

use crate::{
config::{ProducerConfig, RecordKeyAllocationStrategy},
Expand All @@ -13,16 +18,45 @@ use crate::{

const SHARED_KEY: &str = "shared_key";

// Example implementation of the ProducerCallback trait
#[derive(Debug)]
struct BenchmarkProducerCallback {
event_sender: Sender<ProduceCompletionBatchEvent>,
}

impl BenchmarkProducerCallback {
pub fn new(event_sender: Sender<ProduceCompletionBatchEvent>) -> Self {
Self { event_sender }
}
}

impl ProducerCallback for BenchmarkProducerCallback {
fn finished(&self, event: ProduceCompletionBatchEvent) -> BoxFuture<'_, anyhow::Result<()>> {
Box::pin(async {
self.event_sender.send(event).await?;
Ok(())
})
}
}

pub(crate) struct ProducerWorker {
fluvio_producer: TopicProducerPool,
records_to_send: Vec<BenchmarkRecord>,
stat: StatCollector,
_stat: StatCollector,
}
impl ProducerWorker {
pub(crate) async fn new(id: u64, config: ProducerConfig, stat: StatCollector) -> Result<Self> {
pub(crate) async fn new(
id: u64,
config: ProducerConfig,
stat: StatCollector,
event_sender: Sender<ProduceCompletionBatchEvent>,
) -> Result<Self> {
let fluvio = Fluvio::connect().await?;
let callback: SharedProducerCallback =
Arc::new(BenchmarkProducerCallback::new(event_sender));

let fluvio_config = TopicProducerConfigBuilder::default()
.callback(callback)
.batch_size(config.batch_size.as_u64() as usize)
.batch_queue_size(config.queue_size as usize)
.max_request_size(config.max_request_size.as_u64() as usize)
Expand All @@ -39,39 +73,25 @@ impl ProducerWorker {

let num_records = records_per_producer(id, config.num_producers, config.num_records);

println!("producer {} will send {} records", id, num_records);

let records_to_send = create_records(config.clone(), num_records, id);

println!(
"producer {} will send {} records",
id,
records_to_send.len()
);

Ok(ProducerWorker {
fluvio_producer,
records_to_send,
stat,
_stat: stat,
})
}

pub async fn send_batch(mut self) -> Result<()> {
pub async fn send_batch(self) -> Result<()> {
println!("producer is sending batch");

for record in self.records_to_send.into_iter() {
self.stat.start();
let time = std::time::Instant::now();
let send_out = self
let _ = self
.fluvio_producer
.send(record.key, record.data.clone())
.await?;

self.stat.send_out((send_out, time));
self.stat.add_record(record.data.len() as u64).await;
}
self.fluvio_producer.flush().await?;
self.stat.finish();

Ok(())
}
Expand Down
Loading
Loading