Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RuboCop linter offenses #226

Merged
merged 2 commits into from
May 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2023-07-18 20:10:02 UTC using RuboCop version 1.54.2.
# on 2024-05-27 16:23:11 UTC using RuboCop version 1.55.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -64,6 +64,24 @@ RSpec/RepeatedDescription:
Exclude:
- 'spec/requests/active_record_sql_metrics_spec.rb'

# Offense count: 4
# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
# Include: **/*_spec.rb
RSpec/SpecFilePathFormat:
Exclude:
- '**/spec/routing/**/*'
- 'spec/unit/block_instrumentation_spec.rb'
- 'spec/unit/configuration_spec.rb'
- 'spec/unit/sql/normalizer_spec.rb'
- 'spec/unit/sql/query_spec.rb'

# Offense count: 1
# Configuration parameters: Include.
# Include: **/*_spec*rb*, **/spec/**/*
RSpec/SpecFilePathSuffix:
Exclude:
- 'spec/unit/tags.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Rake/Desc:
Expand Down
2 changes: 1 addition & 1 deletion spec/requests/logger_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
get "/metrics"
end

assert_includes out, "error message"
expect(out).to include("error message")
end
end
Loading