Skip to content

Commit

Permalink
fix: fix compilation error
Browse files Browse the repository at this point in the history
  • Loading branch information
gwossum committed Jan 2, 2024
1 parent a51e238 commit 8b587dc
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions services/retention/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ func NewService(c Config) *Service {
}

// OSSDropShardMetaRef creates a closure appropriate for OSS to use as DropShardMetaRef.
func OSSDropShardMetaRef(mc MetaClient) func(uint64) error {
return func(shardID uint64) error {
func OSSDropShardMetaRef(mc MetaClient) func(uint64, []uint64) error {
return func(shardID uint64, owners []uint64) error {
return mc.DropShard(shardID)
}
}
Expand Down Expand Up @@ -194,6 +194,9 @@ func (s *Service) DeletionCheck() {
logger.RetentionPolicy(info.rp),
zap.Error(err))
if errors.Is(err, tsdb.ErrShardNotFound) {
// At first you wouldn't think this could happen, we're iterating over shards
// in the store. However, if this has been a very long running operation the
// shard could have been dropped from the store while we were working on other shards.
log.Warn("Shard does not exist in store, continuing retention removal",
logger.Database(info.db),
logger.Shard(id),
Expand Down

0 comments on commit 8b587dc

Please sign in to comment.