feat: Add segmenting to write buffer and persistence to wal #24610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates the WriteBufferFlusher and OpenBufferSegment. If a wal is passed into the buffer, data written into it will be persisted to the wal for the initialized segment id.
pauldix
force-pushed
the
pd/write-buffer-wal
branch
from
c25605c to
6a55272
Compare
|
Moved this over to #24624 to unhose the git situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the write buffer into its own directory in the crate. It puts writes into a segment, which are persisted into the WAL if it is configured. Writes are buffered up before committed to ensure we don't do file IO with every individual write.
This doesn't yet load data from the wal into the buffer, which will come in a follow on PR. The bootup routine will also need to use the persister to know which wal segments should be loaded into the buffer. Finally, the buffer will need to rotate and persist segments.