fix(inputs.vsphere): Add tags to VSAN ESA disks #15960
Open
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
area/vsphere
fix
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
reviewed
Oct 1, 2024
| @@ -440,8 +441,10 @@ func populateCMMDSTags(tags map[string]string, entityName, uuid string, cmmds ma | |||
| newTags["hostname"] = host.Content.Hostname | |||
| } | |||
| newTags["devicename"] = e.Content.DevName | |||
| if int(e.Content.IsSsd) == 0 { | |||
| newTags["ssduuid"] = e.Content.SsdUUID | |||
| if !(strings.Contains(entityName, "-esa-")) { | |||
There was a problem hiding this comment.
Could you please add a comment to the code noting that the ssduuid is invalid for esa disks? If possible, add a link to a VSphere document describing that fact...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some VSAN metrics e.g. "vsan-esa-disk-layer" and "vsan-esa-disk-scsifw" are missing "hostname" and "devicename" tags.
Fixes: #15938