fix(inputs.snmp_trap): Remove timeout deprecation

[DStrand1]

Summary

Removes the "unused" deprecation from the timeout field as it is still used

Checklist

• No AI generated code was used in this PR

Related issues

resolves #16137

[srebhan]

@DStrand1 one comment. Furthemore, it might be good to add a comment to the setting in the sample.conf that this timeout is only used with the netsnmp translator.

[Hipska]

Looks like I deprecated it (partially) with #10339, but then it got re-added with #11534.

To me, it looks like the timeout should be removed completely, or set it fixed at 5s (a snmptranslate call should never take that long) I think it was added as a fail-save, since the call is run during runtime instead of with inputs.snmp it is only called on initialisation.

[srebhan]

@Hipska it might be true that we should remove the timeout completely, but as it stands now the timeout is used and cannot be deprecated. If you want to remove it, please propose a holistic PR including the removal of the whole code path.

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 2.31 % for linux amd64 (new size: 262.4 MB, nightly size 256.5 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz