feat(inputs.fritzbox): Make inputs.fritzbox an internal plugin #16390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
feat
hdecarne
changed the title
Hipska
suggested changes
Jan 15, 2025
|
@Hipska I have reworked the plugin accordingly (see comments/commits for details). Please let me know if there are additional issues. |
|
@Hipska, thanks for the detailed review. I have reworked the plugin's configuration interface overall as suggested. |
Hipska
reviewed
Jan 20, 2025
… if igdicfg is not available
Hipska
suggested changes
Jan 21, 2025
There was a problem hiding this comment.
All good, just a small correction needed around the wait groups, see this example: https://gobyexample.com/waitgroups
Hipska
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides the inputs.fritzbox plugin for collecting statistics from AVM devices (routers, repeaters, ...). It uses the device's TR-064 interfaces to retrieve the status.
I previously contributed this plugin as an external one. As part of the latest reworks I also converted it into an internal one.
Checklist
Related issues
resolves #16389