docs: update onboarding steps for Go v3 client #6987
Conversation
karel-rehor
changed the title
|
I've decided to go ahead with changes only to GO and will update Java onboarding in another branch. I'd rather we get this part of the UI updated ASAP instead of possibly having it held until January because of 1) Christmas Holidays 2) Unexpected obstacles in updating onboarding for Java. BTW. Not sure what to do about the |
|
Hi @karel-rehor, sorry for the delay on this - I was working on fixing the CI pipeline and I see it has passed the tests now. I'll take a look at this PR in more detail tomorrow. Thank you! |
There was a problem hiding this comment.
Hello! Thanks for doing this! I apologize for not getting to this when I said I would, it slipped my mind completely. Similar to the Java onboarding, it would be helpful for a video demonstrating the changes since I noticed some spacing and formatting changes, but it looks good to me otherwise! If the video size limit is an issue here, let me know and I can run the branch locally to see these changes
| @@ -48,7 +48,8 @@ export const WriteDataComponent = (props: OwnProps) => { | |||
| onSelectBucket(bucket.name) | |||
| }, [bucket, onSelectBucket]) | |||
|
|
|||
| const codeSnippet = `org := "${org.name}" | |||
| const codeSnippet = `// FOO | |||
There was a problem hiding this comment.
I see the // FOO line is the only thing changed here, is that for consistency?
| "count": 40, | ||
| }, | ||
| } | ||
| const writeCodeSnippet = ` data := map[string]map[string]interface{}{ |
There was a problem hiding this comment.
Curious to see what effect this whitespace has on the snippet
| panic(err) | ||
| } | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
Also curious about the whitespace here, looks like the number of spaces in a tab has changed, is that maintained across all snippets in the go onboarding?
There was a problem hiding this comment.
Hi @karel-rehor - thanks for doing this. This looks good based on my review, as long as the rationale for doing this is the same as in the Go PR: i.e., this is just to update to conform to changes to the influxdb v3 client libraries.
Before we approve this to merge in, could you please add a video confirming we don't end up with any visual artifacts here? Thanks very much.
Updates the onboarding steps for Go v3 client
Checklist
Authors and Reviewer(s), please verify the following: