-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add per tranche info for lockups #208
Merged
p-offtermatt
merged 10 commits into
release/v2.x
from
ph/add-per-tranche-info-for-lockups
Dec 18, 2024
Merged
Add per tranche info for lockups #208
p-offtermatt
merged 10 commits into
release/v2.x
from
ph/add-per-tranche-info-for-lockups
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusan-maksimovic
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
p-offtermatt
added a commit
that referenced
this pull request
Jan 8, 2025
* Add per tranche info for lockups * Add PR number * Transform next_round_voting_allowed to be more legible * Add test for per_tranche info on lockups * Appease clippy * Fix minor issues * Make comments more detailed * Regenerate artifacts * Restructure logic for skipping tranche * Regenerate artifacts
p-offtermatt
added a commit
that referenced
this pull request
Jan 9, 2025
* Add per tranche info for lockups (#208) * Add per tranche info for lockups * Add PR number * Transform next_round_voting_allowed to be more legible * Add test for per_tranche info on lockups * Appease clippy * Fix minor issues * Make comments more detailed * Regenerate artifacts * Restructure logic for skipping tranche * Regenerate artifacts * Separate out the extra per tranche info into an extra query (#210) * Separate PerTrancheInfos into separate query * Regenerate artifacts * Recompile contract * Add new message to schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: N/A
Add a description of the changes that this PR introduces and the files that
are the most critical to review.
Adds some information to the
query_all_user_lockups
function. This information is necessary to enable callers to know which lockups can currently vote, and which cannot.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
.changelog
make compile
and included content of the artifacts directory into the PRmake schema
and included generated files into the PR