Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per tranche info for lockups #208

Merged
merged 10 commits into from
Dec 18, 2024

Conversation

p-offtermatt
Copy link
Member

@p-offtermatt p-offtermatt commented Dec 17, 2024

Description

Closes: N/A

Add a description of the changes that this PR introduces and the files that
are the most critical to review.

Adds some information to the query_all_user_lockups function. This information is necessary to enable callers to know which lockups can currently vote, and which cannot.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Targeted the correct branch
  • Included the necessary unit tests
  • Added/adjusted the necessary interchain tests
  • Added a changelog entry in .changelog
  • Compiled the contracts by using make compile and included content of the artifacts directory into the PR
  • Regenerated front-end schema by using make schema and included generated files into the PR
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

@p-offtermatt p-offtermatt changed the base branch from main to release/v2.x December 18, 2024 08:28
contracts/hydro/src/contract.rs Outdated Show resolved Hide resolved
contracts/hydro/src/contract.rs Outdated Show resolved Hide resolved
contracts/hydro/src/contract.rs Outdated Show resolved Hide resolved
contracts/hydro/src/contract.rs Show resolved Hide resolved
@p-offtermatt p-offtermatt marked this pull request as ready for review December 18, 2024 12:40
@p-offtermatt p-offtermatt requested a review from a team as a code owner December 18, 2024 12:40
Copy link
Contributor

@dusan-maksimovic dusan-maksimovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@p-offtermatt p-offtermatt merged commit 0c8e066 into release/v2.x Dec 18, 2024
4 checks passed
p-offtermatt added a commit that referenced this pull request Jan 8, 2025
* Add per tranche info for lockups

* Add PR number

* Transform next_round_voting_allowed to be more legible

* Add test for per_tranche info on lockups

* Appease clippy

* Fix minor issues

* Make comments more detailed

* Regenerate artifacts

* Restructure logic for skipping tranche

* Regenerate artifacts
@p-offtermatt p-offtermatt mentioned this pull request Jan 8, 2025
9 tasks
p-offtermatt added a commit that referenced this pull request Jan 9, 2025
* Add per tranche info for lockups (#208)

* Add per tranche info for lockups

* Add PR number

* Transform next_round_voting_allowed to be more legible

* Add test for per_tranche info on lockups

* Appease clippy

* Fix minor issues

* Make comments more detailed

* Regenerate artifacts

* Restructure logic for skipping tranche

* Regenerate artifacts

* Separate out the extra per tranche info into an extra query (#210)

* Separate PerTrancheInfos into separate query

* Regenerate artifacts

* Recompile contract

* Add new message to schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants