Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borrow function inputs where possible #224

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

dusan-maksimovic
Copy link
Contributor

Description

This PR changes couple of function signatures in the code base that were taking ownership over Deps, Env, etc. to make them use borrowed values. This makes the code more composable, and these functions didn't even need to take ownership.
Also removed comments regarding rounding when converting Decimal to UInt128, since we already decided to do rounding to larger value.

The PR doesn't change the storage, nor the external API, just the internal functions.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Targeted the correct branch
  • Included the necessary unit tests
  • Added/adjusted the necessary interchain tests
  • Added a changelog entry in .changelog
  • Compiled the contracts by using make compile and included content of the artifacts directory into the PR
  • Regenerated front-end schema by using make schema and included generated files into the PR
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

@dusan-maksimovic dusan-maksimovic self-assigned this Feb 3, 2025
@dusan-maksimovic dusan-maksimovic requested a review from a team as a code owner February 3, 2025 14:54
@dusan-maksimovic dusan-maksimovic merged commit ed88739 into main Feb 4, 2025
4 checks passed
@dusan-maksimovic dusan-maksimovic deleted the dusan/borrow-inputs branch February 4, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants