Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop reusable setups for relayer's integration tests #174

Open
Farhad-Shabani opened this issue Jan 9, 2025 · 1 comment
Open

Develop reusable setups for relayer's integration tests #174

Farhad-Shabani opened this issue Jan 9, 2025 · 1 comment

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Jan 9, 2025

Context

Now that the full set of IBC layers has been implemented, the relayer's integration tests, specifically those under ics20.rs (e.g. here), involve multiple steps like contract declaration, deployments, handshakes, and client creations, and so on, which are mostly repetitive across tests. Thus it makes sense to develop reusable testing artifacts. We can streamline the setup process, allowing necessary artifacts to be initialized in just a few lines. This approach will make it easier to focus on writing tests.

A similar method has already been applied to Cairo's contract tests, which could serve as a reference.

Caught my eye while reviewing #172.

@Farhad-Shabani Farhad-Shabani changed the title Develop reusable setups for relayer's integration tests and reduce code duplication Develop reusable setups for relayer's integration tests Jan 9, 2025
@rnbguy
Copy link
Member

rnbguy commented Jan 10, 2025

Totally agree. IMO, it's best to implement these as hermes-sdk components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants