feat(e2e): transfer erc20 token from starknet to cosmos and back #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnbguy
force-pushed
the
rano/e2e/ics20-packet-starknet-cosmos
branch
from
4d5b5d3 to
d4f2c76
Compare
There was a problem hiding this comment.
Thanks Rano for the tests!
Left a few comments and a general suggestion: it’d be better if we split each direction into its own test case. It’ll make debugging way easier later on.
By the way, I opened issue #174, perhaps using a reusable test setup should make it simple to separate the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170
Closes #171
ics20 transfer: starknet -> cosmos -> starknet