-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChainId to Starknet and Comet client state #173
Merged
soareschen
merged 18 commits into
main
from
luca_joss/add-chain-id-field-to-client-state
Jan 15, 2025
+147
−70
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
67573b0
Add ChainId to CometClientState
ljoss17 b21de5c
use MutEncoder and MutDecoder
rnbguy dc55653
Fix clippy
ljoss17 ecb9b21
Update CometClientState in Cairo to add chain_id field
ljoss17 e161183
Add chain ID type to StarknetClientState as Felt type
ljoss17 7467f31
Use String in Rust code for Chain ID in Starknet client state
ljoss17 70009d7
Remove unnecessary Felt to Protobuf wiring
ljoss17 7ced046
Replace remaining Felt chainID types to String
ljoss17 546bd98
use ChainId for chain_id type
rnbguy 9904ef4
debug: this compiles
rnbguy 8fa350e
wire ChainId encoding
rnbguy e0ad541
add cgp trait bounds
rnbguy 848eab5
comment ChainId cgp bound which does not work
rnbguy c31b8e6
Fix chain id encoding
soareschen 898fada
Fix ChainId encoding in Starknet client state
ljoss17 927f443
Update ibc-starknet-cw nix
ljoss17 0ec0354
Remove unwrap
ljoss17 279deb4
Use correct chain ID in ClientState update_state
ljoss17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
debug: this compiles
commit 9904ef4c128897a1d5108c6ee61a46da0bd53d7c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commented out parts in this file are done the same way as
EncodeStarknetConsensusState
andEncodeStarknetHeader
. Not sure why this doesn't work.