Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement create client CLI #227

Merged
merged 9 commits into from
Jan 24, 2025
Merged

Implement create client CLI #227

merged 9 commits into from
Jan 24, 2025

Conversation

seanchen1991
Copy link
Contributor

Closes: #195

@seanchen1991
Copy link
Contributor Author

@soareschen Does the ClientSubCommand need to be added as a variant of AllSubCommands?

@soareschen
Copy link
Collaborator

@soareschen Does the ClientSubCommand need to be added as a variant of AllSubCommands?

Yeah we should add it there.

@soareschen soareschen merged commit 6c75fa5 into main Jan 24, 2025
6 checks passed
@soareschen soareschen deleted the sean/create-client-cli branch January 24, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soareschen soareschen soareschen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cli] Implement create client command
2 participants
@seanchen1991 @soareschen