feat(lc/starknet): verify signed commitment proofs from starknet #242

rnbguy · 2025-01-31T10:25:37Z

closes #229

rnbguy · 2025-01-31T17:59:19Z

relayer/crates/starknet-chain-components/src/impls/starknet_to_cosmos/connection_message.rs

@@ -126,7 +158,7 @@ where
            },
            delay_period,
            update_height,
-            proof_init: counterparty_payload.proof_init.proof_bytes,
+            proof_init,


I successfully managed to sign the proof_init

rnbguy · 2025-01-31T18:00:40Z

relayer/crates/starknet-chain-components/src/impls/starknet_to_cosmos/connection_message.rs

@@ -126,7 +158,7 @@ where
            },
            delay_period,
            update_height,
-            proof_init: counterparty_payload.proof_init.proof_bytes,
+            proof_init,
            // TODO(rano): counterparty_payload has empty proofs?
            // proof_client: counterparty_payload.proof_client.proof_bytes,
            proof_client: vec![0x1],


Looks like these two are skipped. Probably ibc-go doesn't use them after cosmos/ibc-go#7129

rnbguy · 2025-01-31T18:01:13Z

relayer/crates/starknet-chain-components/src/impls/starknet_to_cosmos/connection_message.rs

+            // FIXME(rano): generate the signature
+            proof_ack: dbg!(counterparty_payload.proof_ack.proof_bytes),


Currently, the signature verification fails here. But I don't know how to create the signature at this point without access to ConnectionEnd and ConnectionId at starknet.

I can query the stored counteryparty connection end (starknet) at cosmos, cosmos's own connection id to recreate the ConnectionEnd.

rnbguy · 2025-01-31T19:05:18Z

To generate the proofs -- specifically signatures, I hacked around. This is not ideal.

To generate a signature, I need

starknet consensus root at cosmos (against which the proof is validated)
starknet commitment prefix
ibc path
ibc value

When I am building the message with CosmosChain, I don't have access to StarknetChain. So I can't fetch the consensus_root (block_hash) for starknet.

For now, I pass the block_hash as a dummy proof in the payload -- as I am building the correct proof at message builder anyway.

@soareschen any idea how to do this properly?

soareschen · 2025-01-31T19:43:11Z

I think you need to include that in the payload. You can define a custom payload type for Starknet if needed.

soareschen · 2025-01-31T19:47:15Z

You could also modify the StarknetCommitmentProof type if it is required in all proofs. I think in Cosmos, the root is part of the MerkleProof struct already.

rnbguy · 2025-02-01T00:08:20Z

I ended up building the bytes that need to be signed at the Starknet (-to-Cosmos) payload builder step. But Starknet doesn't have access to the Cosmos's default signer. So I signed it at Cosmos's message builder step.

But I don't see how I can sign the bytes for packet commitment, ack and receipt.

rnbguy · 2025-02-01T00:09:36Z

One more question: is the query_packet_receipt supposed to return non_membership_proof too?

ibc-starknet/relayer/crates/starknet-chain-components/src/impls/queries/packet_receipt.rs

Lines 51 to 57 in a3248f9

    
           async fn query_packet_receipt( 
        
               chain: &Chain, 
        
               channel_id: &ChannelId, 
        
               port_id: &IbcPortId, 
        
               sequence: &IbcSequence, 
        
               height: &u64, 
        
           ) -> Result<(Vec<u8>, StarknetCommitmentProof), Chain::Error> {

... for packet_timeout trigger.

rnbguy · 2025-02-01T00:25:23Z

currently fails because the packet_ack proof from Starknet to Cosmos is not valid, i.e. it is not signed by the cosmos default signer.

rnbguy · 2025-02-01T09:54:41Z

Actually, I think, the default_message_signer (or something equivalent) should be used on the Starknet side at payload builder steps.

The public key is part of the Starknet light client. It should be part of Starknet's context.
We will generate the commitment proofs at payload builder steps directly. The proofs from Starknet should only rely on Starknet's context.

Starknet does have an equivalent to default_message_signer via HasStarknetAccount

ibc-starknet/relayer/crates/starknet-chain-context/src/contexts/chain.rs

Line 192 in c14166f

    
           pub account: SingleOwnerAccount<Arc<JsonRpcClient<HttpTransport>>, LocalWallet>,

But, it uses ecdsa scheme. But we are using secp256k1 in wasm light clients currently.

Probably, we can use relayer_wallet.signing_key to generate a secp256k1 key pair.

ibc-starknet/relayer/crates/starknet-integration-tests/src/contexts/bootstrap.rs

Lines 108 to 111 in a3248f9

    
           let relayer_wallet = wallets 
        
               .get("relayer") 
        
               .ok_or_else(|| StarknetBootstrap::raise_error("expect relayer wallet to be present"))? 
        
               .clone();

rnbguy · 2025-02-04T12:11:24Z

I fixed the signing problems. But now I think, I need to make the commitment proofs consistent between ibc-go and cairo contract.

This is how ibc-go generate the commitment proof

https://github.com/cosmos/ibc-go/blob/98d7e7550a23ecf8d96ce042ab11ef857b184f2a/modules/core/04-channel/types/packet.go#L20-L36

In cairo, we use the following

ibc-starknet/cairo-contracts/packages/core/src/commitment/types.cairo

Lines 51 to 59 in 7967c80

    
           pub fn compute_packet_commitment( 
        
               json_packet_data: @ByteArray, timeout_height: Height, timeout_timestamp: Timestamp 
        
           ) -> Commitment { 
        
               let mut coll = U32CollectorImpl::init(); 
        
               coll.extend(timeout_timestamp); 
        
               coll.extend(timeout_height); 
        
               coll.extend_from_chunk(compute_sha256_byte_array(json_packet_data)); 
        
               compute_sha256_u32_array(coll.value(), 0, 0).into() 
        
           }

I should try to fix it using this test as a reference,

ibc-starknet/cairo-contracts/packages/core/src/tests/commitment.cairo

Lines 52 to 58 in 7967c80

    
           fn test_compute_packet_commitment() { 
        
               let commitment = PACKET_COMMITMENT_ON_SN(ERC20()); 
        
               let expected: [u32; 8] = [ 
        
                   3458244073, 1576048754, 4210798310, 1002247062, 2365181318, 2763927782, 545147151, 944653547 
        
               ]; 
        
               assert_eq!(commitment, expected.into()); 
        
           }

rnbguy · 2025-02-04T14:57:26Z

relayer/crates/starknet-chain-components/src/impls/queries/client_state.rs

+        let chain_status = chain.query_chain_status().await?;
+
+        // FIXME: CometClientState can't be encoded to protobuf
+        let protobuf_encoded_client_state = Vec::new();


do we have an implementation that encodes CometClientState to protobuf encoding?

cc @soareschen

PS. it's not important for demo2, as ibc-go currently ignored self client/consensus validation.

rnbguy · 2025-02-04T14:57:52Z

relayer/crates/starknet-chain-components/src/impls/queries/consensus_state.rs

+        let chain_status = chain.query_chain_status().await?;
+
+        // FIXME: CometConsensusState can't be encoded to protobuf
+        let protobuf_encoded_consensus_state = Vec::new();


@soareschen same as client state, but for consensus state.

rnbguy · 2025-02-04T14:58:18Z

relayer/crates/starknet-chain-components/src/impls/queries/packet_receipt.rs

+        if receipt_status {
+            return Err(Chain::raise_error(
+                "Packet is received. No non-membership proof.",
+            ));
+        }


I only return non-membership proof here.

rnbguy · 2025-02-04T14:59:11Z

cairo-contracts/packages/core/src/commitment/types.cairo

+    // ibc-go uses nanosecs
+    // https://github.com/cosmos/ibc-go/blob/98d7e7550a23ecf8d96ce042ab11ef857b184f2a/proto/ibc/core/channel/v1/channel.proto#L179-L180
+    coll.extend(timeout_timestamp.timestamp * 1_000_000_000);


I fixed this as part of this PR.

cc @Farhad-Shabani

rnbguy · 2025-02-04T15:04:39Z

Nix error during Osmosis github tarball fetch is back. But ics20 e2e test passes locally. 🎉

rnbguy · 2025-02-04T16:24:10Z

We have to remove or trim the light_client.rs tesfile.

We are passing dummy proofs here:

ibc-starknet/relayer/crates/starknet-integration-tests/src/tests/light_client.rs

Lines 394 to 396 in 7967c80

    
           proof_try: [0; 32].into(), // dummy proofs 
        
           proof_client: [0; 32].into(), 
        
           proof_consensus: [0; 32].into(),

ibc-starknet/relayer/crates/starknet-integration-tests/src/tests/light_client.rs

Line 442 in 7967c80

proof_try: [0; 32].into(), // dummy proofs

The wasm light client accepts only signed proofs now.

rnbguy added 3 commits January 31, 2025 11:14

update ibc-client-cw patch branch

a5f39fd

fix cw context methods

01290a9

impl cw client state execution for starknet

e3080cf

rnbguy force-pushed the rano/starknet-to-cosmos-commitment-proofs branch from cdd28da to 124d5d0 Compare January 31, 2025 11:48

rnbguy added 2 commits January 31, 2025 13:30

add membership proof signer

de53ed2

sign connection open try message

07e36a1

rnbguy force-pushed the rano/starknet-to-cosmos-commitment-proofs branch from 124d5d0 to 07e36a1 Compare January 31, 2025 17:57

rnbguy commented Jan 31, 2025

View reviewed changes

rnbguy added 2 commits January 31, 2025 19:56

ignore client and consensus proof

59ec68f

open ack proof

d71ba5d

todo comment

776aa81

rnbguy added 5 commits February 1, 2025 00:33

generate membership proof message at starknet payload

311be49

membership proof msg for channel end

4c465ac

membership proof msg for packet commitment

cbaf6be

membership proof msg for packet ack

02d4d6b

membership proof msg for packet receipt

7722d4d

rnbguy force-pushed the rano/starknet-to-cosmos-commitment-proofs branch from 5828ef2 to 7722d4d Compare February 1, 2025 00:00

rename field in StarknetCommitmentProof

cb4fa8d

rm redundant todos

c14166f

rnbguy added 2 commits February 3, 2025 15:05

sign self client and consensus state proofs

426a861

use chain_status height as proof height

fd25041

rnbguy and others added 7 commits February 4, 2025 12:00

add tiny-bip39 dep

043f2a1

proof_signer components

e233c3e

add proof_signer field to StarknetChain

56b8427

generate secp256k1 keypair from felt signing key

0ad7614

sign with starknet proof signer

da71d3c

Merge branch 'main' into rano/starknet-to-cosmos-commitment-proofs

c6ba01e

nits

becea65

rnbguy added 4 commits February 4, 2025 15:54

rm redundant endpoint

7644902

use packet_receipt endpoint

46931e2

ibc-go compatible packet commitment

e1e9c15

test consistent packet commitment in cairo and rust

aa5bc01

rnbguy force-pushed the rano/starknet-to-cosmos-commitment-proofs branch from 076afec to aa5bc01 Compare February 4, 2025 14:54

rnbguy marked this pull request as ready for review February 4, 2025 14:55

rnbguy requested review from soareschen and Farhad-Shabani February 4, 2025 14:55

rnbguy commented Feb 4, 2025

View reviewed changes

happy clippy

8f5ce48

rnbguy added 4 commits February 4, 2025 17:25

rm test steps with dummy proofs

1db25f1

cargo fmt

205756e

cargo clippy

b84c5c4

update expected commitment hash after fix

b8f240b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lc/starknet): verify signed commitment proofs from starknet #242

feat(lc/starknet): verify signed commitment proofs from starknet #242

rnbguy commented Jan 31, 2025

rnbguy Jan 31, 2025

rnbguy Jan 31, 2025

rnbguy Jan 31, 2025

rnbguy Jan 31, 2025

rnbguy commented Jan 31, 2025

soareschen commented Jan 31, 2025

soareschen commented Jan 31, 2025

rnbguy commented Feb 1, 2025

rnbguy commented Feb 1, 2025 •

edited

Loading

rnbguy commented Feb 1, 2025

rnbguy commented Feb 1, 2025 •

edited

Loading

rnbguy commented Feb 4, 2025

rnbguy Feb 4, 2025

rnbguy Feb 4, 2025

rnbguy Feb 4, 2025

rnbguy Feb 4, 2025

rnbguy commented Feb 4, 2025

rnbguy commented Feb 4, 2025

		// FIXME(rano): generate the signature
		proof_ack: dbg!(counterparty_payload.proof_ack.proof_bytes),

feat(lc/starknet): verify signed commitment proofs from starknet #242

Are you sure you want to change the base?

feat(lc/starknet): verify signed commitment proofs from starknet #242

Conversation

rnbguy commented Jan 31, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rnbguy commented Jan 31, 2025

soareschen commented Jan 31, 2025

soareschen commented Jan 31, 2025

rnbguy commented Feb 1, 2025

rnbguy commented Feb 1, 2025 • edited Loading

rnbguy commented Feb 1, 2025

rnbguy commented Feb 1, 2025 • edited Loading

rnbguy commented Feb 4, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rnbguy commented Feb 4, 2025

rnbguy commented Feb 4, 2025

rnbguy commented Feb 1, 2025 •

edited

Loading

rnbguy commented Feb 1, 2025 •

edited

Loading