-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(abci): ABCI shim for running against a standalone ABCI app #463
Draft
jmalicevic
wants to merge
18
commits into
main
Choose a base branch
from
jasmina/tmp_abci_app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
===========================================
- Coverage 83.87% 71.26% -12.61%
===========================================
Files 111 135 +24
Lines 7570 8948 +1378
===========================================
+ Hits 6349 6376 +27
- Misses 1221 2572 +1351
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
abci
ABCI Interface
code
Code/implementation related
P: low
Priority: low
work in progress
Work in progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #479
TODO
ExtendVote
VerifyVoteExtension
The changes below allow Malachite to call into a standalone ABCI based app running on a socket whose address is defined below.
The application used can be found in the following repo:
Instructions to run for a two node setup:
/tmp/kvstoreplusplus0.sock
/tmp/kvstoreplusplus1.sock
./scripts/spawn.bash --home x --nodes 2
In the log files of malachite you should be seeing transactions showing up (the printf from the actor).
The application is setup to send transactions in
PrepareProposal
, stores them in a local variable withinProcessProposal
and checks whether they are received again inFinalizeBlock
.Malachite takes the transactions from the decided block in
Decide
and sends them to the app inFinalizeBlock
.If there is any mismatch the app will panic.
PR author checklist