fix(code/core-consensus): Reproduce and fix consensus being stuck with byzantine proposer

[ancazamfir]

Closes: #850
See: #857

---

PR author checklist

For all contributors

• Reference GitHub issue
• Ensure PR title follows the conventional commits spec

For external contributors

• Maintainers of Malachite are allowed to push changes to the branch

[codecov]

❌ 10 Tests Failed:

Tests completed	Failed	Passed	Skipped
149	10	139	0

View the top 3 failed test(s) by shortest run time

informalsystems-malachitebft-test::it wal::non_proposer_crashes_after_voting_parts_only

Stack Traces | 7.59s run time

No failure message available

informalsystems-malachitebft-test::it vote_sync_bcast::start_late

Stack Traces | 60s run time

No failure message available

informalsystems-malachitebft-test::it vote_sync_bcast::crash_restart_from_latest

Stack Traces | 60s run time

No failure message available

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[romac]

Good idea! Maybe we should allow the test framework to trigger such behavior, what do you think? Will think about how to implement that properly

[ancazamfir]

Yes, let's discuss. Also to figure out how to enable byzantine proposer.

[ancazamfir]

@romac what do you think about making a minimal PR with just the changes required to eliminate the vote equivocation.
Meaning only with the changes in:

core-consensus/src/handle/driver.rs
core-consensus/src/state.rs
core-driver/src/driver.rs

We can merge to main if CI is green and then we can continue on this PR.

[romac]

Here is the PR with only those changes: #864