Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visitor and transformer for params #1384

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix visitor and transformer for params #1384

merged 1 commit into from
Feb 29, 2024

Conversation

shonfeder
Copy link
Contributor

Followup for #1371
Contributes to #1298

I forgot to add visitor logic for the parameter type annotations

  • Tests added for any new code
  • Documentation added for any new functionality
  • Entries added to the respective CHANGELOG.md for any new functionality
  • Feature table on README.md updated for any listed functionality

Fix visitor and transformer for params
cc1ffab 
Followup for #1371

I forgot to add visitor logic for the parameter type annotations
@shonfeder shonfeder marked this pull request as ready for review February 29, 2024 17:20
@shonfeder shonfeder requested a review from bugarela February 29, 2024 17:20
@shonfeder shonfeder merged commit 3c55068 into main Feb 29, 2024
15 checks passed
@shonfeder shonfeder deleted the 1298/fix-visitors-for-params branch February 29, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugarela bugarela bugarela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shonfeder @bugarela