Apply code review suggestions

informatici · Sep 26, 2024 · 60258ef · 60258ef
1 parent 034c23d
commit 60258ef
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/src/main/java/org/isf/security/jwt/TokenProvider.java b/src/main/java/org/isf/security/jwt/TokenProvider.java
@@ -83,11 +83,11 @@ public void init() {
 		byte[] keyBytes = secret.getBytes(StandardCharsets.UTF_8);
 		this.key = Keys.hmacShaKeyFor(keyBytes);
 
-		// 15 minutes (900,000 milliseconds)
-		this.tokenValidityInMilliseconds = 1000L * 60 * 15;
+		// 30 minutes (900,000 milliseconds)
+		this.tokenValidityInMilliseconds = 1000L * 60 * 30;
 
-		// 7 days (604,800,000 milliseconds)
-		this.tokenValidityInMillisecondsForRememberMe = 1000L * 60 * 60 * 24 * 7;
+		// 3 days (604,800,000 milliseconds)
+		this.tokenValidityInMillisecondsForRememberMe = 1000L * 60 * 60 * 24 * 3;
 
 		this.jwtParser = Jwts.parserBuilder().setSigningKey(this.key).build();
 	}
@@ -163,9 +163,8 @@ public String generateRefreshToken(Authentication authentication) {
 	public Authentication getAuthentication(String token) {
 		final Claims claims = getAllClaimsFromToken(token);
 
-		/* 
-		 * claims.get(AUTHORITIES_KEY) cannot be null, at least an empty string
-		 * Left for security but not testable
+		/*
+		 * claims.get(AUTHORITIES_KEY) cannot be null, at least an empty string Left for security but not testable
 		 */
 		String authoritiesClaim = claims.get(AUTHORITIES_KEY) != null ? claims.get(AUTHORITIES_KEY).toString() : "";
 		if (authoritiesClaim.isEmpty()) {
@@ -190,9 +189,8 @@ public Authentication getAuthenticationByUsername(String username) {
 	public TokenValidationResult validateToken(String token) {
 		try {
 			Claims claims = Jwts.parserBuilder().setSigningKey(key).build().parseClaimsJws(token).getBody();
-			/* 
-			 * If claims.getSubject() not null for sure is not empy.
-			 * Left here for security but not testable
+			/*
+			 * If claims.getSubject() not null for sure is not empy. Left here for security but not testable
 			 */
 			if (claims.getSubject() == null || claims.getSubject().isEmpty()) {
 				throw new IllegalArgumentException("JWT claims string is empty.");